DescriptionRevert of Enable Control Flow Integrity for the official Linux Chrome. Try 6. (patchset #1 id:1 of https://codereview.chromium.org/1529993002/ )
Reason for revert:
Causes link to time out: https://chromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20trunk/builds/11345
Original issue's description:
> Enable Control Flow Integrity for the official Linux Chrome. Try 6.
>
> This CL turns on CFI, a security check:
> https://sites.google.com/a/chromium.org/dev/developers/testing/control-flow-integrity
> http://clang.llvm.org/docs/ControlFlowIntegrity.html
>
> This feature enables LTO (Link-Time Optimization) builds, which slow down the linker by 3x-4x.
> CFI also comes with a code size overhead of about 7%-9%. The runtime CPU cost is less than 1%,
> and should not be an issue.
>
> BUG=chromium:464797
> Intent to Implement thread:
> https://groups.google.com/a/chromium.org/d/msg/chromium-dev/pbJqt6ccMII/7iJC2oklCAAJ
>
> This is a sixth attempt to land the CL. Previous attempts:
> https://codereview.chromium.org/1502373003/
> https://codereview.chromium.org/1501593003/
> https://codereview.chromium.org/1393283005/
> https://codereview.chromium.org/1502233004/
> https://codereview.chromium.org/1513623004/
>
> The last time it failed, it was primarily due to the perf build slaves
> being much slower then the local build or other GCE slaves,
> see https://crbug.com/569732. This is still under investigation,
> and the timeout has been increased in the mean time:
> https://codereview.chromium.org/1528533003/
>
> Committed: https://crrev.com/14cb7878cb522ad05480547690ec3990f4bbb156
> Cr-Commit-Position: refs/heads/master@{#365486}
TBR=thestig@chromium.org,thakis@chromium.org,pcc@google.com,krasin@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:464797
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|