Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 1528533003: Increase the timeout for the perf buildbots. (Closed)

Created:
5 years ago by krasin
Modified:
5 years ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kcc, pcc
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Increase the timeout for the perf buildbots. For some reasons, perf slaves link Chrome almost twice slower than a local machine, and ~1.5 slower than other GCE slaves. Increasing the timeout to remedy the immediate issue. BUG=chromium:464797 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298023

Patch Set 1 #

Total comments: 2

Patch Set 2 : add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M masters/master.chromium.chrome/master.cfg View 1 1 chunk +2 lines, -1 line 0 comments Download
M masters/master.chromium.perf/master.cfg View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
krasin
The actual link time for Chrome on perf buildbots is 67 minutes. This timeout also ...
5 years ago (2015-12-15 02:13:14 UTC) #2
imkrasin
5 years ago (2015-12-15 04:05:46 UTC) #4
imkrasin
5 years ago (2015-12-15 04:06:05 UTC) #5
Alexander Potapenko
lgtm https://codereview.chromium.org/1528533003/diff/1/masters/master.chromium.chrome/master.cfg File masters/master.chromium.chrome/master.cfg (right): https://codereview.chromium.org/1528533003/diff/1/masters/master.chromium.chrome/master.cfg#newcode97 masters/master.chromium.chrome/master.cfg:97: 'factory': m_annotator.BaseFactory('chromium', timeout=4800), I'm guessing this is a ...
5 years ago (2015-12-15 17:40:13 UTC) #7
krasin
https://codereview.chromium.org/1528533003/diff/1/masters/master.chromium.chrome/master.cfg File masters/master.chromium.chrome/master.cfg (right): https://codereview.chromium.org/1528533003/diff/1/masters/master.chromium.chrome/master.cfg#newcode97 masters/master.chromium.chrome/master.cfg:97: 'factory': m_annotator.BaseFactory('chromium', timeout=4800), On 2015/12/15 17:40:13, Alexander Potapenko wrote: ...
5 years ago (2015-12-15 17:49:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528533003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528533003/20001
5 years ago (2015-12-15 17:50:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=298023
5 years ago (2015-12-15 17:52:24 UTC) #13
Dirk Pranke
The change lgtm, but the fact that using LTO/CFI causes the link to take 67 ...
5 years ago (2015-12-15 23:14:18 UTC) #14
krasin
5 years ago (2015-12-15 23:18:58 UTC) #15
Message was sent while issue was closed.
On 2015/12/15 23:14:18, Dirk Pranke wrote:
> The change lgtm, but the fact that using LTO/CFI causes the link to take 67
> minutes (and take 32 GB of ram) is *brutal*. What hope is there for this to be
> sped up?

The problem is something to do with the perf slaves.
My local machine links the official Chrome with CFI in 27-28 minutes. Perf
slaves more than 2x slower. More updates are here: https://crbug.com/569732
Such difference is incomprehensible to me. Compute Engine could not be that
slow.

Powered by Google App Engine
This is Rietveld 408576698