Add VPUSH/VPOP instructions to the ARM32 integrated assembler.

Add VPUSH/VPOP instructions to the ARM32 integrated assembler.

Also fixes the corresponding emit methods for vpush and vpop to match
constraint that the maximum number of consecutive registers that can
be pushed/popped is 16.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a3c32146545c7c54c465606d5b5e71882ddb56e6

[Karl, 2015-12-17 23:49:01]

Description was changed from

==========
Add VPUSH/VPOP instructions to the ARM32 integrated assembler.

Also fixes the corresponding emit methods for vpush and vpop to match
constraint that the maximum number of consecutive registers that can
be pushed/popped is 16.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add VPUSH/VPOP instructions to the ARM32 integrated assembler.

Also fixes the corresponding emit methods for vpush and vpop to match
constraint that the maximum number of consecutive registers that can
be pushed/popped is 16.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2015-12-17 23:49:01]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[John, 2015-12-18 00:02:32]

lgtm

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:1976: IValueT BaseReg = getEncodedSRegNum(OpBaseReg);
Optional: const on everything that's a const

https://codereview.chromium.org/1532233002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vpush.ll (right):

https://codereview.chromium.org/1532233002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vpush.ll:55: call void @foo()
Move the call to line 65?

[Jim Stichnoth, 2015-12-18 00:03:11]

otherwise lgtm

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:206: assert(Var->hasReg() &&
RegARM32::isEncodedSReg(Var->getRegNum()));
Better to change
  assert(c1 && c2);
into
  assert(c1);
  assert(c2);

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:1979: assert(0 < NumConsecRegs && NumConsecRegs <=
VpushVpopMaxConsecRegs &&
Break this into 3 asserts, as above.

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:1998: const char *VpopName = "vpop";
constexpr for these 2 vars

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:2013: const char *VpushName = "vpush";
constexpr

https://codereview.chromium.org/1532233002/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1532233002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1389: assert((Var && Var->hasReg()) && "pop only applies to
registers");
I think you can assume Var!=nullptr, and remove that test from the assert?

[Karl, 2015-12-18 16:26:22]

Description was changed from

==========
Add VPUSH/VPOP instructions to the ARM32 integrated assembler.

Also fixes the corresponding emit methods for vpush and vpop to match
constraint that the maximum number of consecutive registers that can
be pushed/popped is 16.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
==========

to

==========
Add VPUSH/VPOP instructions to the ARM32 integrated assembler.

Also fixes the corresponding emit methods for vpush and vpop to match
constraint that the maximum number of consecutive registers that can
be pushed/popped is 16.

BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4334
R=jpp@chromium.org, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Karl, 2015-12-18 16:26:25]

Committed patchset #3 (id:40001) manually as
a3c32146545c7c54c465606d5b5e71882ddb56e6 (presubmit successful).

[Karl, 2015-12-18 16:26:51]

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.cpp
File src/IceAssemblerARM32.cpp (right):

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:206: assert(Var->hasReg() &&
RegARM32::isEncodedSReg(Var->getRegNum()));
On 2015/12/18 00:03:11, stichnot wrote:
> Better to change
>   assert(c1 && c2);
> into
>   assert(c1);
>   assert(c2);

Done.

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:1976: IValueT BaseReg = getEncodedSRegNum(OpBaseReg);
On 2015/12/18 00:02:31, John wrote:
> Optional: const on everything that's a const

Done.

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:1979: assert(0 < NumConsecRegs && NumConsecRegs <=
VpushVpopMaxConsecRegs &&
On 2015/12/18 00:03:11, stichnot wrote:
> Break this into 3 asserts, as above.

Done.

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:1998: const char *VpopName = "vpop";
On 2015/12/18 00:03:10, stichnot wrote:
> constexpr for these 2 vars

Done.

https://codereview.chromium.org/1532233002/diff/20001/src/IceAssemblerARM32.c...
src/IceAssemblerARM32.cpp:2013: const char *VpushName = "vpush";
On 2015/12/18 00:03:11, stichnot wrote:
> constexpr

Done.

https://codereview.chromium.org/1532233002/diff/20001/src/IceInstARM32.cpp
File src/IceInstARM32.cpp (right):

https://codereview.chromium.org/1532233002/diff/20001/src/IceInstARM32.cpp#ne...
src/IceInstARM32.cpp:1389: assert((Var && Var->hasReg()) && "pop only applies to
registers");
On 2015/12/18 00:03:11, stichnot wrote:
> I think you can assume Var!=nullptr, and remove that test from the assert?

Done.

https://codereview.chromium.org/1532233002/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/vpush.ll (right):

https://codereview.chromium.org/1532233002/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/vpush.ll:55: call void @foo()
On 2015/12/18 00:02:31, John wrote:
> Move the call to line 65?

Done.