move libevent into base

move libevent into base

This simplifies the process of bootstrapping gn standalone.

And libevent is not really used outside of base. base is actually its only client.

BUG=569352
TEST=See CL for details for how to reproduce this.
R=thestig@chromium.org
TBR=cpu@chromium.org

Committed: https://crrev.com/c7ebe6daa79da2e351345065020cc7f216126f15
Cr-Commit-Position: refs/heads/master@{#366282}

[Lei Zhang, 2015-12-17 21:55:59]

You have a lot of red bots. Can you check and make sure you got all the
dependencies switched over?

Also, the commit message is a bit too detailed. Feel free to write it in a
comment in the CL, and just say "This simplifies the process of bootstrapping gn
standalone. See CL for details"

[Lei Zhang, 2015-12-17 21:58:08]

Otherwise this looks ok.

[tfarina, 2015-12-17 21:59:20]

On Thu, Dec 17, 2015 at 7:55 PM, <thestig@chromium.org> wrote:

> You have a lot of red bots. Can you check and make sure you got all the
> dependencies switched over?
>
Yep. I have uploaded to run the trybots. Still working on it. :)

Should have added "WIP" to the subject ;)


>
> Also, the commit message is a bit too detailed. Feel free to write it in a
> comment in the CL, and just say "This simplifies the process of
> bootstrapping gn
> standalone. See CL for details"
>
> Sure, I'll make this change before posting.


> https://codereview.chromium.org/1531573008/
>



-- 
Thiago Farina

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2015-12-18 22:06:38]

Lei, I'm posting a comment with the instructions as comment here, as you
suggested, as I'm going to remove it from the CL description:

Before:

$ mkdir gn-standalone
$ cd gn-standalone
$ mkdir tools
$ cd tools
$ git clone https://chromium.googlesource.com/chromium/src/tools/gn
$ cd ..
$ mkdir -p third_party/libevent
$ cd third_party/libevent
$ wget --no-check-certificate
https://chromium.googlesource.com/chromium/chromium/+archive/master/third_par...
$ tar -xvzf libevent.tar.gz
$ cd ../..
$ git clone https://chromium.googlesource.com/chromium/src/base
$ git clone https://chromium.googlesource.com/chromium/src/build
$ mkdir testing
$ cd testing
$ git clone https://chromium.googlesource.com/chromium/testing/gtest
$ cd ..
$ ./tools/gn/bootstrap/bootstrap.py -s

[tfarina, 2015-12-18 22:08:23]

Description was changed from

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.

Before you would have to do this:

$ mkdir gn-standalone
$ cd gn-standalone
$ mkdir tools
$ cd tools
$ git clone https://chromium.googlesource.com/chromium/src/tools/gn
$ cd ..
$ mkdir -p third_party/libevent
$ cd third_party/libevent
$ wget --no-check-certificate
https://chromium.googlesource.com/chromium/chromium/+archive/master/third_par...
$ tar -xvzf libevent.tar.gz
$ cd ../..
$ git clone https://chromium.googlesource.com/chromium/src/base
$ git clone https://chromium.googlesource.com/chromium/src/build
$ git clone https://chromium.googlesource.com/chromium/src/build/config
$ mkdir testing
$ cd testing
$ git clone https://chromium.googlesource.com/chromium/testing/gtest
$ cd ..
$ ./tools/gn/bootstrap/bootstrap.py -s

After this, you can avoid the libevent steps:

$ mkdir gn-standalone
$ cd gn-standalone
$ mkdir tools
$ cd tools
$ git clone https://chromium.googlesource.com/chromium/src/tools/gn
$ cd ..
$ git clone https://chromium.googlesource.com/chromium/src/base
$ git clone https://chromium.googlesource.com/chromium/src/build
$ git clone https://chromium.googlesource.com/chromium/src/build/config
$ mkdir testing
$ cd testing
$ git clone https://chromium.googlesource.com/chromium/testing/gtest
$ cd ..
$ ./tools/gn/bootstrap/bootstrap.py -s

BUG=569352
R=thestig@chromium.org
==========

to

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.
See CL for details.

BUG=569352
R=thestig@chromium.org
==========

[tfarina, 2015-12-18 22:08:46]

Description was changed from

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.
See CL for details.

BUG=569352
R=thestig@chromium.org
==========

to

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.

BUG=569352
TEST=See CL for details for how to reproduce this.
R=thestig@chromium.org
==========

[tfarina, 2015-12-18 22:09:27]

Description was changed from

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.

BUG=569352
TEST=See CL for details for how to reproduce this.
R=thestig@chromium.org
==========

to

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.

And libevent is not really used outside of base. base is actually its only
client.

BUG=569352
TEST=See CL for details for how to reproduce this.
R=thestig@chromium.org
==========

[Lei Zhang, 2015-12-18 22:13:10]

BTW, there's still a reference to third_party/libevent in base/DEPS.

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
File build/linux/unbundle/libevent.gyp (left):

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
build/linux/unbundle/libevent.gyp:1: # Copyright 2013 The Chromium Authors. All
rights reserved.
Do you want to try to convert this rather than deleting it?

[tfarina, 2015-12-18 22:13:34]

After, should be really just:

$ mkdir gn-standalone
$ cd gn-standalone
$ mkdir tools
$ cd tools
$ git clone https://chromium.googlesource.com/chromium/src/tools/gn
$ cd ..
$ git clone https://chromium.googlesource.com/chromium/src/base
$ git clone https://chromium.googlesource.com/chromium/src/build
$ mkdir testing
$ cd testing
$ git clone https://chromium.googlesource.com/chromium/testing/gtest
$ cd ..
$ ./tools/gn/bootstrap/bootstrap.py -s

[tfarina, 2015-12-18 22:18:02]

I just updated the base/DEPS before you posted! :)

I can revert the changes to build/linux/unbundle/libevent.gyp if want. Just say,
and I will do.

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
File build/linux/unbundle/libevent.gyp (left):

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
build/linux/unbundle/libevent.gyp:1: # Copyright 2013 The Chromium Authors. All
rights reserved.
On 2015/12/18 22:13:10, Lei Zhang wrote:
> Do you want to try to convert this rather than deleting it?

How this could ever works? Our version was patched to include by "" rather than
<>

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
build/linux/unbundle/libevent.gyp:18: '../../build/shim_headers.gypi',
I suppose I should just update this?

[Lei Zhang, 2015-12-18 22:28:43]

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
File build/linux/unbundle/libevent.gyp (left):

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
build/linux/unbundle/libevent.gyp:1: # Copyright 2013 The Chromium Authors. All
rights reserved.
On 2015/12/18 22:18:02, tfarina wrote:
> On 2015/12/18 22:13:10, Lei Zhang wrote:
> > Do you want to try to convert this rather than deleting it?
> 
> How this could ever works? Our version was patched to include by "" rather
than
> <>

I don't know. You'll have to ask Pawel.

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
build/linux/unbundle/libevent.gyp:18: '../../build/shim_headers.gypi',
On 2015/12/18 22:18:02, tfarina wrote:
> I suppose I should just update this?

Mmmmhmmm.

[tfarina, 2015-12-18 22:39:55]

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
File build/linux/unbundle/libevent.gyp (left):

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
build/linux/unbundle/libevent.gyp:1: # Copyright 2013 The Chromium Authors. All
rights reserved.
On 2015/12/18 22:28:43, Lei Zhang wrote:
> On 2015/12/18 22:18:02, tfarina wrote:
> > On 2015/12/18 22:13:10, Lei Zhang wrote:
> > > Do you want to try to convert this rather than deleting it?
> > 
> > How this could ever works? Our version was patched to include by "" rather
> than
> > <>
> 
> I don't know. You'll have to ask Pawel.

Hum. OK.

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
build/linux/unbundle/libevent.gyp:18: '../../build/shim_headers.gypi',
Btw! Isn't this path already broken? To me, wouldn't ../.. give you './build/'?
and thus ../../build/shim_headers.gypi, would go to
./build/build/shim_headers.gypi? Shouldn't this be ../../shim_headers.gypi? I
think the only correct is this one
https://code.google.com/p/chromium/codesearch#chromium/src/build/linux/unbund...

[Lei Zhang, 2015-12-18 22:52:22]

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
File build/linux/unbundle/libevent.gyp (left):

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
build/linux/unbundle/libevent.gyp:18: '../../build/shim_headers.gypi',
On 2015/12/18 22:39:55, tfarina wrote:
> Btw! Isn't this path already broken? To me, wouldn't ../.. give you
'./build/'?
> and thus ../../build/shim_headers.gypi, would go to
> ./build/build/shim_headers.gypi? Shouldn't this be ../../shim_headers.gypi? I
> think the only correct is this one
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/linux/unbund...

If you see how this unbundle business works, this file gets copied and
overwrites third_party/libevent/libevent.gyp. With this file's content in
third_party/libevent/libevent.gyp, then ../../build/shim_headers.gypi refers to
the correct path.

[tfarina, 2015-12-18 23:31:28]

Lei, I have restored the bundle changes. PTAL.

[Lei Zhang, 2015-12-18 23:43:03]

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
File build/linux/unbundle/libevent.gyp (left):

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
build/linux/unbundle/libevent.gyp:18: '../../build/shim_headers.gypi',
This should be changed to ../../../build/shim_headers.gypi because that's how
base/third_party/libevent/libevent.gyp would refer to shim_headers.gypi.

[Lei Zhang, 2015-12-18 23:43:33]

And with that, lgtm

[tfarina, 2015-12-19 00:04:12]

Thank you Lei!

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
File build/linux/unbundle/libevent.gyp (left):

https://codereview.chromium.org/1531573008/diff/100001/build/linux/unbundle/l...
build/linux/unbundle/libevent.gyp:18: '../../build/shim_headers.gypi',
On 2015/12/18 23:43:02, Lei Zhang wrote:
> This should be changed to ../../../build/shim_headers.gypi because that's how
> base/third_party/libevent/libevent.gyp would refer to shim_headers.gypi.

Done.

[tfarina, 2015-12-19 13:47:48]

tfarina@chromium.org changed reviewers:
+ cpu@chromium.org

[tfarina, 2015-12-19 13:47:49]

TBRing Carlos for the changes outside of base.

[tfarina, 2015-12-19 13:48:34]

Description was changed from

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.

And libevent is not really used outside of base. base is actually its only
client.

BUG=569352
TEST=See CL for details for how to reproduce this.
R=thestig@chromium.org
==========

to

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.

And libevent is not really used outside of base. base is actually its only
client.

BUG=569352
TEST=See CL for details for how to reproduce this.
R=thestig@chromium.org
TBR=cpu@chromium.org
==========

[tfarina, 2015-12-19 13:48:49]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-12-19 13:48:50]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1531573008/#ps160001
(title: "fix shim path")

[commit-bot: I haz the power, 2015-12-19 13:49:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531573008/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531573008/160001

[commit-bot: I haz the power, 2015-12-19 13:55:36]

Description was changed from

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.

And libevent is not really used outside of base. base is actually its only
client.

BUG=569352
TEST=See CL for details for how to reproduce this.
R=thestig@chromium.org
TBR=cpu@chromium.org
==========

to

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.

And libevent is not really used outside of base. base is actually its only
client.

BUG=569352
TEST=See CL for details for how to reproduce this.
R=thestig@chromium.org
TBR=cpu@chromium.org
==========

[commit-bot: I haz the power, 2015-12-19 13:55:38]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-12-19 13:56:46]

Description was changed from

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.

And libevent is not really used outside of base. base is actually its only
client.

BUG=569352
TEST=See CL for details for how to reproduce this.
R=thestig@chromium.org
TBR=cpu@chromium.org
==========

to

==========
move libevent into base

This simplifies the process of bootstrapping gn standalone.

And libevent is not really used outside of base. base is actually its only
client.

BUG=569352
TEST=See CL for details for how to reproduce this.
R=thestig@chromium.org
TBR=cpu@chromium.org

Committed: https://crrev.com/c7ebe6daa79da2e351345065020cc7f216126f15
Cr-Commit-Position: refs/heads/master@{#366282}
==========

[commit-bot: I haz the power, 2015-12-19 13:56:47]

Patchset 9 (id:??) landed as
https://crrev.com/c7ebe6daa79da2e351345065020cc7f216126f15
Cr-Commit-Position: refs/heads/master@{#366282}