On 2015/12/18 22:18:02, tfarina wrote:
> On 2015/12/18 22:13:10, Lei Zhang wrote:
> > Do you want to try to convert this rather than deleting it?
>
> How this could ever works? Our version was patched to include by "" rather
than
> <>
On 2015/12/18 22:28:43, Lei Zhang wrote:
> On 2015/12/18 22:18:02, tfarina wrote:
> > On 2015/12/18 22:13:10, Lei Zhang wrote:
> > > Do you want to try to convert this rather than deleting it?
> >
> > How this could ever works? Our version was patched to include by "" rather
> than
> > <>
>
> I don't know. You'll have to ask Pawel.
Hum. OK.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 {
6 'targets': [
7 {
8 'target_name': 'libevent',
9 'type': 'none',
10 'toolsets': ['host', 'target'],
11 'variables': {
12 'headers_root_path': '.',
13 'header_filenames': [
14 'event.h',
15 ],
16 },
17 'includes': [
18 '../../build/shim_headers.gypi',
tfarina
2015/12/18 22:18:02
I suppose I should just update this?
On 2015/12/18 22:18:02, tfarina wrote:
> I suppose I should just update this?
Mmmmhmmm.
tfarina
2015/12/18 22:39:55
Btw! Isn't this path already broken? To me, wouldn
Btw! Isn't this path already broken? To me, wouldn't ../.. give you './build/'?
and thus ../../build/shim_headers.gypi, would go to
./build/build/shim_headers.gypi? Shouldn't this be ../../shim_headers.gypi? I
think the only correct is this one
https://code.google.com/p/chromium/codesearch#chromium/src/build/linux/unbund...
Lei Zhang
2015/12/18 22:52:22
If you see how this unbundle business works, this
On 2015/12/18 22:39:55, tfarina wrote:
> Btw! Isn't this path already broken? To me, wouldn't ../.. give you
'./build/'?
> and thus ../../build/shim_headers.gypi, would go to
> ./build/build/shim_headers.gypi? Shouldn't this be ../../shim_headers.gypi? I
> think the only correct is this one
>
https://code.google.com/p/chromium/codesearch#chromium/src/build/linux/unbund...
If you see how this unbundle business works, this file gets copied and
overwrites third_party/libevent/libevent.gyp. With this file's content in
third_party/libevent/libevent.gyp, then ../../build/shim_headers.gypi refers to
the correct path.
Lei Zhang
2015/12/18 23:43:02
This should be changed to ../../../build/shim_head
This should be changed to ../../../build/shim_headers.gypi because that's how
base/third_party/libevent/libevent.gyp would refer to shim_headers.gypi.
On 2015/12/18 23:43:02, Lei Zhang wrote:
> This should be changed to ../../../build/shim_headers.gypi because that's how
> base/third_party/libevent/libevent.gyp would refer to shim_headers.gypi.
Issue 1531573008: move libevent into base
(Closed)
Created 5 years ago by tfarina
Modified 5 years ago
Reviewers: Lei Zhang, cpu_(ooo_6.6-7.5)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 10