Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1531513002: Include /usr/lib/pkgconfig files in sysroot image (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include /usr/share/pkgconfig files in sysroot image The whole of /usr/share was previously being excluded which meant that our sysroot builds were relying on .pc files from the host environment in some cases. This change requires https://codereview.chromium.org/1531513002 BUG=569947 Committed: https://crrev.com/d746383f4d7a3e5dce13796fbdf400392245c22d Cr-Commit-Position: refs/heads/master@{#365570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M build/linux/sysroot_scripts/sysroot-creator.sh View 5 chunks +19 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (6 generated)
Lei Zhang
lgtm
5 years ago (2015-12-16 01:32:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1531513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1531513002/1
5 years ago (2015-12-16 18:03:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 18:29:10 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-16 18:30:46 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d746383f4d7a3e5dce13796fbdf400392245c22d
Cr-Commit-Position: refs/heads/master@{#365570}

Powered by Google App Engine
This is Rietveld 408576698