Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1530683003: Add libpthread-stubs0-dev to sysroot image (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Raphael Kubo da Costa (rakuco)
Base URL:
https://chromium.googlesource.com/chromium/src.git@sysroot_pkgconfig
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add libpthread-stubs0-dev to sysroot image This is required by the xcb pkg-config file but has gone unnoticed since most host systems have this installed. BUG=569949 Committed: https://crrev.com/475c72a09a1167c4cf70fa99503a7f3fa3117f79 Cr-Commit-Position: refs/heads/master@{#365384}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M build/linux/sysroot_scripts/packagelist.wheezy.amd64 View 1 chunk +1 line, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.arm View 1 chunk +1 line, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.i386 View 1 chunk +1 line, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.wheezy.mipsel View 1 chunk +1 line, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-wheezy.sh View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Sam Clegg
5 years ago (2015-12-15 21:57:54 UTC) #3
Lei Zhang
lgtm, I made a small edit to the CL desc to fix a typo.
5 years ago (2015-12-15 22:05:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530683003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530683003/20001
5 years ago (2015-12-15 22:38:48 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-15 23:23:56 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-15 23:25:30 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/475c72a09a1167c4cf70fa99503a7f3fa3117f79
Cr-Commit-Position: refs/heads/master@{#365384}

Powered by Google App Engine
This is Rietveld 408576698