Remove OmahaUpdateInfoBar and related classes

Remove OmahaUpdateInfoBar and related classes

BUG=566085
Committed: https://crrev.com/e0b2c1bd6b0f46bcc5bcaca4a0cde96edfd511ae
Cr-Commit-Position: refs/heads/master@{#367207}

[Theresa, 2015-12-17 23:44:39]

twellington@chromium.org changed reviewers:
+ dfalcantara@chromium.org, holte@chromium.org

[Theresa, 2015-12-17 23:44:40]

dfalcantara@ ptal at everything
holte@ ptal at histograms.xml (removed a few that are no longer needed since the
infobar is being replaced with a menu item)

[gone, 2015-12-18 00:50:02]

Everything but the histogram change lgtm

https://codereview.chromium.org/1531013006/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1531013006/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:14773: -<histogram
name="GoogleUpdate.InfoBar.ActionTaken"
I don't think you're supposed to delete histograms -- just mark them obsolete.

[Theresa, 2015-12-18 17:40:36]

hotel@ ptal at histograms.xml (this change only marks 3 as obsolete)

https://codereview.chromium.org/1531013006/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1531013006/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:14773: -<histogram
name="GoogleUpdate.InfoBar.ActionTaken"
On 2015/12/18 00:50:02, dfalcantara wrote:
> I don't think you're supposed to delete histograms -- just mark them obsolete.

Done.

[Theresa, 2015-12-18 17:40:54]

On 2015/12/18 17:40:36, Theresa Wellington wrote:
> hotel@ ptal at histograms.xml (this change only marks 3 as obsolete)
> 
>
https://codereview.chromium.org/1531013006/diff/1/tools/metrics/histograms/hi...
> File tools/metrics/histograms/histograms.xml (left):
> 
>
https://codereview.chromium.org/1531013006/diff/1/tools/metrics/histograms/hi...
> tools/metrics/histograms/histograms.xml:14773: -<histogram
> name="GoogleUpdate.InfoBar.ActionTaken"
> On 2015/12/18 00:50:02, dfalcantara wrote:
> > I don't think you're supposed to delete histograms -- just mark them
obsolete.
> 
> Done.

*holte

[Yaron, 2015-12-22 15:26:38]

yfriedman@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Yaron, 2015-12-22 15:26:38]

https://codereview.chromium.org/1531013006/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1531013006/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:14783: <histogram
name="GoogleUpdate.InfoBar.InternalStorageSizeAvailable" units="MB">
Can you add this metric back to your new impl? We have reason to believe that a
non-trivial %-age of users can't update due to lack of space.

[Theresa, 2015-12-28 21:26:25]

On 2015/12/22 15:26:38, Yaron (OOO until Jan 4) wrote:
>
https://codereview.chromium.org/1531013006/diff/40001/tools/metrics/histogram...
> File tools/metrics/histograms/histograms.xml (left):
> 
>
https://codereview.chromium.org/1531013006/diff/40001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:14783: <histogram
> name="GoogleUpdate.InfoBar.InternalStorageSizeAvailable" units="MB">
> Can you add this metric back to your new impl? We have reason to believe that
a
> non-trivial %-age of users can't update due to lack of space.

I added a new "GoogleUpdate.MenuItem.InternalStorageSizeAvailable" with the same
logic as the old InfoBar histogram: https://codereview.chromium.org/1553433003/

[Theresa, 2015-12-29 00:24:59]

On 2015/12/28 21:26:25, Theresa Wellington wrote:
> On 2015/12/22 15:26:38, Yaron (OOO until Jan 4) wrote:
> >
>
https://codereview.chromium.org/1531013006/diff/40001/tools/metrics/histogram...
> > File tools/metrics/histograms/histograms.xml (left):
> > 
> >
>
https://codereview.chromium.org/1531013006/diff/40001/tools/metrics/histogram...
> > tools/metrics/histograms/histograms.xml:14783: <histogram
> > name="GoogleUpdate.InfoBar.InternalStorageSizeAvailable" units="MB">
> > Can you add this metric back to your new impl? We have reason to believe
that
> a
> > non-trivial %-age of users can't update due to lack of space.
> 
> I added a new "GoogleUpdate.MenuItem.InternalStorageSizeAvailable" with the
same
> logic as the old InfoBar histogram:
https://codereview.chromium.org/1553433003/

Per an offline discussion w/ Dan, I decided to keep the original InfoBar
histogram in case we re-enable the infobar (better to have one histogram
tracking internal storage size available than two).

[Theresa, 2015-12-30 18:16:16]

holte@ ptal (marking 2 histograms obsolete)

Landed the other two related changes and rebased this patchset.

[Steven Holte, 2015-12-30 20:44:19]

histograms.xml lgtm

[Theresa, 2015-12-30 22:20:55]

twellington@chromium.org changed reviewers:
+ vadimsh@chromium.org

[Theresa, 2015-12-30 22:20:55]

+vadimsh@ - ptal removal of chrome/test/data/android/omahaupdateinfobar/ from
chrome_public_test_apk.isolate

[Vadim Sh., 2015-12-30 23:08:20]

*.isolate lgtm

[Theresa, 2015-12-30 23:09:14]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2015-12-30 23:09:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/1531013006/#ps120001
(title: "Remove chrome/test/data/android/omahaupdateinfobar/ from
chrome_public_test_apk.isolate")

[commit-bot: I haz the power, 2015-12-30 23:09:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1531013006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1531013006/120001

[commit-bot: I haz the power, 2015-12-30 23:59:37]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-12-31 00:00:42]

Description was changed from

==========
Remove OmahaUpdateInfoBar and related classes

BUG=566085
==========

to

==========
Remove OmahaUpdateInfoBar and related classes

BUG=566085

Committed: https://crrev.com/e0b2c1bd6b0f46bcc5bcaca4a0cde96edfd511ae
Cr-Commit-Position: refs/heads/master@{#367207}
==========

[commit-bot: I haz the power, 2015-12-31 00:00:43]

Patchset 7 (id:??) landed as
https://crrev.com/e0b2c1bd6b0f46bcc5bcaca4a0cde96edfd511ae
Cr-Commit-Position: refs/heads/master@{#367207}