Chromium Code Reviews Chromium Code Reviews
Issue 1531013006:
Remove OmahaUpdateInfoBar and related classes (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index b4d637fa8986b8c5ea82c7c4958fd14df0a2ec7a..83d2d03aad709eff060fe6494301314dda86984b 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -14770,35 +14770,6 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <summary>The HRESULT for a failed on-demand update check.</summary> |
| </histogram> |
| -<histogram name="GoogleUpdate.InfoBar.ActionTaken" |
|
gone
2015/12/18 00:50:02
I don't think you're supposed to delete histograms
Theresa
2015/12/18 17:40:36
Done.
|
| - enum="GoogleUpdateInfoBarActions"> |
| - <owner>yfriedman@chromium.org</owner> |
| - <owner>dfalcantara@chromium.org</owner> |
| - <summary> |
| - (Android-only) Records what action the user took (if any) on the InfoBar |
| - indicating that a new version of Chrome is available. |
| - </summary> |
| -</histogram> |
| - |
| -<histogram name="GoogleUpdate.InfoBar.InternalStorageSizeAvailable" units="MB"> |
| - <owner>yfriedman@chromium.org</owner> |
| - <owner>dfalcantara@chromium.org</owner> |
| - <owner>khushalsagar@chromium.org</owner> |
| - <summary> |
| - (Android-only) The amount of internal memory storage available on the user's |
| - device when the InfoBar is shown. |
| - </summary> |
| -</histogram> |
| - |
| -<histogram name="GoogleUpdate.InfoBar.TimeShown" units="milliseconds"> |
| - <owner>yfriedman@chromium.org</owner> |
| - <owner>dfalcantara@chromium.org</owner> |
| - <summary> |
| - (Android-only) The amount of time which the InfoBar indicating a new version |
| - is available is visible. |
| - </summary> |
| -</histogram> |
| - |
| <histogram name="GoogleUpdate.InstallerExitCode" enum="InstallStatus"> |
| <owner>grt@chromium.org</owner> |
| <summary> |
| @@ -65971,13 +65942,6 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <int value="9" label="GOOGLE_UPDATE_DISABLED_BY_POLICY_AUTO_ONLY"/> |
| </enum> |
| -<enum name="GoogleUpdateInfoBarActions" type="int"> |
| - <int value="0" label="Clicked close"/> |
| - <int value="1" label="Clicked to update appears successful"/> |
| - <int value="2" label="Clicked to update but failed"/> |
| - <int value="3" label="InfoBar dismissed implicitly (no interaction)"/> |
| -</enum> |
| - |
| <enum name="GoogleUpdateMenuItemActions" type="int"> |
| <int value="0" label="Not clicked"/> |
| <int value="1" label="Clicked, intent launched"/> |
