Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1531013006: Remove OmahaUpdateInfoBar and related classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove chrome/test/data/android/omahaupdateinfobar/ from chrome_public_test_apk.isolate Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
index 31cdf81a010a5d0dae8b3d51ff61a733fafe54e2..bc8b28ea482e0e82d5703d2ce17f8625bd6d47e7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
@@ -519,13 +519,11 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
@Override
public void onLoadStopped(Tab tab, boolean toDifferentDocument) {
postDeferredStartupIfNeeded();
- showUpdateInfoBarIfNecessary();
}
@Override
public void onPageLoadFinished(Tab tab) {
postDeferredStartupIfNeeded();
- showUpdateInfoBarIfNecessary();
OfflinePageUtils.showOfflineSnackbarIfNecessary(ChromeActivity.this, tab);
}
@@ -695,7 +693,6 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
}
});
- getChromeApplication().getUpdateInfoBarHelper().checkForUpdateOnBackgroundThread(this);
UpdateMenuItemHelper.getInstance().checkForUpdateOnBackgroundThread(this);
removeSnapshotDatabase();
@@ -1012,13 +1009,6 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
}
/**
- * @return Whether the update infobar may be shown.
- */
- public boolean mayShowUpdateInfoBar() {
- return true;
- }
-
- /**
* Add the specified tab to bookmarks or allows to edit the bookmark if the specified tab is
* already bookmarked. If a new bookmark is added, a snackbar will be shown.
* @param tabToBookmark The tab that needs to be bookmarked.
@@ -1524,10 +1514,6 @@ public abstract class ChromeActivity extends AsyncInitializationActivity
}
}
- private void showUpdateInfoBarIfNecessary() {
- getChromeApplication().getUpdateInfoBarHelper().showUpdateInfobarIfNecessary(this);
- }
-
/**
* Determines whether the ContentView is currently visible and not hidden by an overlay
* @return true if the ContentView is fully hidden by another view (i.e. the tab stack)

Powered by Google App Engine
This is Rietveld 408576698