Split up text painting code into separate functions to setup paint and then paint text.

Split up text painting code into separate functions to setup paint and then paint text.

This enables plumbing custom paint before painting text.

BUG=512354
Committed: https://crrev.com/0ed86a2c1dd1711c391543801c4ba056dd9712df
Cr-Commit-Position: refs/heads/master@{#365798}

[ramya.v, 2015-12-16 13:08:45]

ramya.v@samsung.com changed reviewers:
+ fs@opera.com, pdr@chromium.org, rob.buis@samsung.com

[ramya.v, 2015-12-16 13:08:46]

PTAL!

Thanks

[fs, 2015-12-16 13:21:41]

LGTM w/ nits (we might want to cleanup the "old" paintText, but that is probably
better done in a follow-up.)

https://codereview.chromium.org/1530853002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp (right):

https://codereview.chromium.org/1530853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp:300: TextRun&
textRun, const SVGTextFragment& fragment, LayoutSVGResourceMode resourceMode,
SkPaint& paint)
This doesn't really use textRun and fragment, so those can be removed.

https://codereview.chromium.org/1530853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp:341: void
SVGInlineTextBoxPainter::paintText(const PaintInfo& paintInfo, TextRun& textRun,
const SVGTextFragment& fragment, int startPosition, int endPosition, SkPaint&
paint)
const SkPaint& ?

[ramya.v, 2015-12-17 04:25:46]

Updated as per review comments. PTAL!

Thanks

https://codereview.chromium.org/1530853002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp (right):

https://codereview.chromium.org/1530853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp:300: TextRun&
textRun, const SVGTextFragment& fragment, LayoutSVGResourceMode resourceMode,
SkPaint& paint)
On 2015/12/16 13:21:41, fs wrote:
> This doesn't really use textRun and fragment, so those can be removed.

Done.

https://codereview.chromium.org/1530853002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp:341: void
SVGInlineTextBoxPainter::paintText(const PaintInfo& paintInfo, TextRun& textRun,
const SVGTextFragment& fragment, int startPosition, int endPosition, SkPaint&
paint)
On 2015/12/16 13:21:41, fs wrote:
> const SkPaint& ?

Done.

[fs, 2015-12-17 09:19:55]

The CQ bit was checked by fs@opera.com

[fs, 2015-12-17 09:19:55]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/1530853002/#ps40001
(title: "Updated as per review comments")

[commit-bot: I haz the power, 2015-12-17 09:19:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530853002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530853002/40001

[commit-bot: I haz the power, 2015-12-17 10:45:14]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-17 10:46:28]

Description was changed from

==========
Split up text painting code into separate functions to setup paint and then
paint text.

This enables plumbing custom paint before painting text.

BUG=512354
==========

to

==========
Split up text painting code into separate functions to setup paint and then
paint text.

This enables plumbing custom paint before painting text.

BUG=512354

Committed: https://crrev.com/0ed86a2c1dd1711c391543801c4ba056dd9712df
Cr-Commit-Position: refs/heads/master@{#365798}
==========

[commit-bot: I haz the power, 2015-12-17 10:46:29]

Patchset 3 (id:??) landed as
https://crrev.com/0ed86a2c1dd1711c391543801c4ba056dd9712df
Cr-Commit-Position: refs/heads/master@{#365798}