third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h - Issue 1530853002: Split up text painting code into separate functions to setup paint and then paint text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h

Issue 1530853002: Split up text painting code into separate functions to setup paint and then paint text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated as per review comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h

diff --git a/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h b/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h

index cc82684429860350af6e2cbe426305e6195ef218..8e2e09bf32faebfd888c9ff89f3bdefe9f7aa539 100644

--- a/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h

+++ b/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h

@@ -34,7 +34,8 @@ private:

bool shouldPaintSelection(const PaintInfo&) const;

void paintTextFragments(const PaintInfo&, LayoutObject&);

void paintDecoration(const PaintInfo&, TextDecoration, const SVGTextFragment&);

- void paintTextWithShadows(const PaintInfo&, const ComputedStyle&, TextRun&, const SVGTextFragment&, int startPosition, int endPosition, LayoutSVGResourceMode);

+ bool setupTextPaint(const PaintInfo&, const ComputedStyle&, LayoutSVGResourceMode, SkPaint&);

+ void paintText(const PaintInfo&, TextRun&, const SVGTextFragment&, int startPosition, int endPosition, const SkPaint&);

void paintText(const PaintInfo&, const ComputedStyle&, const ComputedStyle& selectionStyle, const SVGTextFragment&, LayoutSVGResourceMode, bool shouldPaintSelection);

const SVGInlineTextBox& m_svgInlineTextBox;

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp » ('j') | no next file with comments »