Split up text painting code into separate functions to setup paint and then paint text.

third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/paint/SVGInlineTextBoxPainter.h"
 
 #include "core/editing/Editor.h"
 #include "core/editing/markers/DocumentMarkerController.h"
 #include "core/editing/markers/RenderedDocumentMarker.h"
@@ skipping 278 matching lines @@
             }
             break;
         case PT_MARKERS:
             break;
         default:
             ASSERT_NOT_REACHED();
         }
     }
 }
 
-void SVGInlineTextBoxPainter::paintTextWithShadows(const PaintInfo& paintInfo, const ComputedStyle& style,
-    TextRun& textRun, const SVGTextFragment& fragment, int startPosition, int endPosition,
-    LayoutSVGResourceMode resourceMode)
+bool SVGInlineTextBoxPainter::setupTextPaint(const PaintInfo& paintInfo, const ComputedStyle& style,
+    TextRun& textRun, const SVGTextFragment& fragment, LayoutSVGResourceMode resourceMode, SkPaint& paint)

[fs, 2015/12/16 13:21:41]

This doesn't really use textRun and fragment, so those can be removed.

[ramya.v, 2015/12/17 04:25:46]

Done.

 {
     LayoutSVGInlineText& textLayoutObject = toLayoutSVGInlineText(*LineLayoutPaintShim::layoutObjectFrom(m_svgInlineTextBox.lineLayoutItem()));
 
     float scalingFactor = textLayoutObject.scalingFactor();
     ASSERT(scalingFactor);
 
-    const Font& scaledFont = textLayoutObject.scaledFont();
     const ShadowList* shadowList = style.textShadow();
-    GraphicsContext& context = paintInfo.context;
 
     // Text shadows are disabled when printing. http://crbug.com/258321
     bool hasShadow = shadowList && !paintInfo.isPrinting();
 
-    FloatPoint textOrigin(fragment.x, fragment.y);
-    FloatSize textSize(fragment.width, fragment.height);
     AffineTransform paintServerTransform;
     const AffineTransform* additionalPaintServerTransform = 0;
 
-    GraphicsContextStateSaver stateSaver(context, false);
     if (scalingFactor != 1) {
-        textOrigin.scale(scalingFactor, scalingFactor);
-        textSize.scale(scalingFactor);
-        stateSaver.save();
-        context.scale(1 / scalingFactor, 1 / scalingFactor);
         // Adjust the paint-server coordinate space.
         paintServerTransform.scale(scalingFactor);
         additionalPaintServerTransform = &paintServerTransform;
     }
 
-    SkPaint paint;
     if (!SVGPaintContext::paintForLayoutObject(paintInfo, style, *LineLayoutPaintShim::layoutObjectFrom(m_svgInlineTextBox.parent()->lineLayoutItem()), resourceMode, paint, additionalPaintServerTransform))
-        return;
+        return false;
     paint.setAntiAlias(true);
 
     if (hasShadow) {
         OwnPtr<DrawLooperBuilder> drawLooperBuilder = shadowList->createDrawLooper(DrawLooperBuilder::ShadowRespectsAlpha, style.visitedDependentColor(CSSPropertyColor));
         RefPtr<SkDrawLooper> drawLooper = drawLooperBuilder->detachDrawLooper();
         paint.setLooper(drawLooper.get());
     }
 
     if (resourceMode == ApplyToStrokeMode) {
         StrokeData strokeData;
         SVGLayoutSupport::applyStrokeStyleToStrokeData(strokeData, style, *LineLayoutPaintShim::layoutObjectFrom(m_svgInlineTextBox.parent()->lineLayoutItem()));
         if (style.svgStyle().vectorEffect() != VE_NON_SCALING_STROKE)
             strokeData.setThickness(strokeData.thickness() * scalingFactor);
         strokeData.setupPaint(&paint);
     }
+    return true;
+}
+
+void SVGInlineTextBoxPainter::paintText(const PaintInfo& paintInfo, TextRun& textRun, const SVGTextFragment& fragment, int startPosition, int endPosition, SkPaint& paint)

[fs, 2015/12/16 13:21:41]

const SkPaint& ?

[ramya.v, 2015/12/17 04:25:45]

Done.

+{
+    LayoutSVGInlineText& textLayoutObject = toLayoutSVGInlineText(*LineLayoutPaintShim::layoutObjectFrom(m_svgInlineTextBox.lineLayoutItem()));
+    const Font& scaledFont = textLayoutObject.scaledFont();
+
+    float scalingFactor = textLayoutObject.scalingFactor();
+    ASSERT(scalingFactor);
+
+    FloatPoint textOrigin(fragment.x, fragment.y);
+    FloatSize textSize(fragment.width, fragment.height);
+
+    GraphicsContext& context = paintInfo.context;
+    GraphicsContextStateSaver stateSaver(context, false);
+    if (scalingFactor != 1) {
+        textOrigin.scale(scalingFactor, scalingFactor);
+        textSize.scale(scalingFactor);
+        stateSaver.save();
+        context.scale(1 / scalingFactor, 1 / scalingFactor);
+    }
 
     TextRunPaintInfo textRunPaintInfo(textRun);
     textRunPaintInfo.from = startPosition;
     textRunPaintInfo.to = endPosition;
 
     float baseline = scaledFont.fontMetrics().floatAscent();
     textRunPaintInfo.bounds = FloatRect(textOrigin.x(), textOrigin.y() - baseline,
         textSize.width(), textSize.height());
 
     context.drawText(scaledFont, textRunPaintInfo, textOrigin, paint);
 }
 
 void SVGInlineTextBoxPainter::paintText(const PaintInfo& paintInfo, const ComputedStyle& style,
     const ComputedStyle& selectionStyle, const SVGTextFragment& fragment,
     LayoutSVGResourceMode resourceMode, bool shouldPaintSelection)
 {
     int startPosition = 0;
     int endPosition = 0;
     if (shouldPaintSelection) {
         m_svgInlineTextBox.selectionStartEnd(startPosition, endPosition);
         shouldPaintSelection = m_svgInlineTextBox.mapStartEndPositionsIntoFragmentCoordinates(fragment, startPosition, endPosition);
     }
 
     // Fast path if there is no selection, just draw the whole chunk part using the regular style
     TextRun textRun = m_svgInlineTextBox.constructTextRun(style, fragment);
     if (!shouldPaintSelection || startPosition >= endPosition) {
-        paintTextWithShadows(paintInfo, style, textRun, fragment, 0, fragment.length, resourceMode);
+        SkPaint paint;
+        if (setupTextPaint(paintInfo, style, textRun, fragment, resourceMode, paint))
+            paintText(paintInfo, textRun, fragment, 0, fragment.length, paint);
         return;
     }
 
     // Eventually draw text using regular style until the start position of the selection
     bool paintSelectedTextOnly = paintInfo.phase == PaintPhaseSelection;
-    if (startPosition > 0 && !paintSelectedTextOnly)
-        paintTextWithShadows(paintInfo, style, textRun, fragment, 0, startPosition, resourceMode);
+    if (startPosition > 0 && !paintSelectedTextOnly) {
+        SkPaint paint;
+        if (setupTextPaint(paintInfo, style, textRun, fragment, resourceMode, paint))
+            paintText(paintInfo, textRun, fragment, 0, startPosition, paint);
+    }
 
     // Draw text using selection style from the start to the end position of the selection
     if (style != selectionStyle) {
         StyleDifference diff;
         diff.setNeedsPaintInvalidationObject();
         SVGResourcesCache::clientStyleChanged(LineLayoutPaintShim::layoutObjectFrom(m_svgInlineTextBox.parent()->lineLayoutItem()), diff, selectionStyle);
     }
 
-    paintTextWithShadows(paintInfo, selectionStyle, textRun, fragment, startPosition, endPosition, resourceMode);
+    SkPaint paint;
+    if (setupTextPaint(paintInfo, selectionStyle, textRun, fragment, resourceMode, paint))
+        paintText(paintInfo, textRun, fragment, startPosition, endPosition, paint);
 
     if (style != selectionStyle) {
         StyleDifference diff;
         diff.setNeedsPaintInvalidationObject();
         SVGResourcesCache::clientStyleChanged(LineLayoutPaintShim::layoutObjectFrom(m_svgInlineTextBox.parent()->lineLayoutItem()), diff, style);
     }
 
     // Eventually draw text using regular style from the end position of the selection to the end of the current chunk part
-    if (endPosition < static_cast<int>(fragment.length) && !paintSelectedTextOnly)
-        paintTextWithShadows(paintInfo, style, textRun, fragment, endPosition, fragment.length, resourceMode);
+    if (endPosition < static_cast<int>(fragment.length) && !paintSelectedTextOnly) {
+        SkPaint paint;
+        if (setupTextPaint(paintInfo, style, textRun, fragment, resourceMode, paint))
+            paintText(paintInfo, textRun, fragment, endPosition, fragment.length, paint);
+    }
 }
 
 void SVGInlineTextBoxPainter::paintTextMatchMarker(GraphicsContext& context, const LayoutPoint&, DocumentMarker* marker, const ComputedStyle& style, const Font& font)
 {
     // SVG is only interested in the TextMatch markers.
     if (marker->type() != DocumentMarker::TextMatch)
         return;
 
     LayoutSVGInlineText& textLayoutObject = toLayoutSVGInlineText(*LineLayoutPaintShim::layoutObjectFrom(m_svgInlineTextBox.lineLayoutItem()));
 
@@ skipping 32 matching lines @@
                 if (!fragmentTransform.isIdentity())
                     context.concatCTM(fragmentTransform);
                 context.setFillColor(color);
                 context.fillRect(fragmentRect, color);
             }
         }
     }
 }
 
 } // namespace blink