Fix UB function problems for shaders and mask.

Fix UB function problems for shaders and mask.

BUG=skia:4634
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1530743002

Committed: https://skia.googlesource.com/skia/+/dafd044e4aea529f88d899247678d4549f776388

Committed: https://skia.googlesource.com/skia/+/c7a784cc8cb1c1dfcd39a32b2170ffe547904e9f

[herb_g, 2015-12-15 22:31:37]

Description was changed from

==========
Fix UB function problems for shaders and mask.

BUG=skia:4634
==========

to

==========
Fix UB function problems for shaders and mask.

BUG=skia:4634
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[herb_g, 2015-12-15 22:56:15]

herb@google.com changed reviewers:
+ mtklein@google.com

[herb_g, 2015-12-15 22:56:26]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-15 22:56:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530743002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530743002/1

[herb_g, 2015-12-15 22:56:46]

This is a second try. Please ignore the first.

[commit-bot: I haz the power, 2015-12-15 22:57:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 22:57:21]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)

[herb_g, 2015-12-15 23:01:05]

fix externals

[herb_g, 2015-12-15 23:01:36]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-15 23:01:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530743002/20001

[commit-bot: I haz the power, 2015-12-15 23:15:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 23:15:30]

Dry run: This issue passed the CQ dry run.

[mtklein, 2015-12-15 23:36:24]

lgtm

[herb_g, 2015-12-16 15:22:36]

The CQ bit was checked by herb@google.com

[commit-bot: I haz the power, 2015-12-16 15:22:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530743002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530743002/20001

[commit-bot: I haz the power, 2015-12-16 15:24:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 15:24:08]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[mtklein, 2015-12-17 15:15:04]

mtklein@google.com changed reviewers:
+ reed@google.com

[mtklein, 2015-12-17 15:15:05]

+Mike for include/

Do we have any external shaders?  Is ShadeProc actually or incidentally public?

[reed1, 2015-12-17 18:12:14]

https://codereview.chromium.org/1530743002/diff/20001/include/core/SkShader.h
File include/core/SkShader.h (right):

https://codereview.chromium.org/1530743002/diff/20001/include/core/SkShader.h...
include/core/SkShader.h:152: typedef void (*ShadeProc)(const void* ctx, int x,
int y, SkPMColor[], int count);
Its seems odd to me that this is declared const, since the logical equivalent is
to just call shadeSpan(), which is not const.

Can the caller in BitmapProc just not make its local variable const?

[reed1, 2015-12-17 18:20:06]

On 2015/12/17 15:15:05, mtklein wrote:
> +Mike for include/
> 
> Do we have any external shaders?  Is ShadeProc actually or incidentally
public?

Likely just an accident. Lets try to take it private.

[herb_g, 2015-12-17 19:58:17]

add comment about const

[herb_g, 2015-12-17 19:59:23]

PTAL

https://codereview.chromium.org/1530743002/diff/20001/include/core/SkShader.h
File include/core/SkShader.h (right):

https://codereview.chromium.org/1530743002/diff/20001/include/core/SkShader.h...
include/core/SkShader.h:152: typedef void (*ShadeProc)(const void* ctx, int x,
int y, SkPMColor[], int count);
On 2015/12/17 at 18:12:14, reed1 wrote:
> Its seems odd to me that this is declared const, since the logical equivalent
is to just call shadeSpan(), which is not const.
> 
> Can the caller in BitmapProc just not make its local variable const?

Added comment as per our discussion.

[reed1, 2015-12-17 20:29:50]

lgtm

[herb_g, 2015-12-17 20:41:15]

The CQ bit was checked by herb@google.com

[herb_g, 2015-12-17 20:41:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1530743002/#ps40001
(title: "add comment about const")

[commit-bot: I haz the power, 2015-12-17 20:41:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530743002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530743002/40001

[commit-bot: I haz the power, 2015-12-17 22:22:37]

Description was changed from

==========
Fix UB function problems for shaders and mask.

BUG=skia:4634
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fix UB function problems for shaders and mask.

BUG=skia:4634
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/dafd044e4aea529f88d899247678d4549f776388
==========

[commit-bot: I haz the power, 2015-12-17 22:22:37]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/dafd044e4aea529f88d899247678d4549f776388

[herb_g, 2015-12-18 16:50:00]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1534243002/ by herb@google.com.

The reason for reverting is: Breaks man gold tests..

[herb_g, 2015-12-18 17:25:20]

The CQ bit was checked by herb@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-18 17:25:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530743002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530743002/60001

[herb_g, 2015-12-18 17:25:41]

Fixed problem with 16-bit masks. PTAL

[mtklein, 2015-12-18 17:27:37]

lgtm

[commit-bot: I haz the power, 2015-12-18 17:46:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-18 17:46:28]

Dry run: This issue passed the CQ dry run.

[herb_g, 2015-12-18 17:51:36]

The CQ bit was checked by herb@google.com

[herb_g, 2015-12-18 17:51:36]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1530743002/#ps60001
(title: "fix 16-bit masks")

[commit-bot: I haz the power, 2015-12-18 17:51:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530743002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530743002/60001

[mtklein, 2015-12-18 17:51:48]

On 2015/12/18 at 17:46:28, commit-bot wrote:
> Dry run: This issue passed the CQ dry run.

No diffs on CQ!

[commit-bot: I haz the power, 2015-12-18 17:52:17]

Description was changed from

==========
Fix UB function problems for shaders and mask.

BUG=skia:4634
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/dafd044e4aea529f88d899247678d4549f776388
==========

to

==========
Fix UB function problems for shaders and mask.

BUG=skia:4634
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/dafd044e4aea529f88d899247678d4549f776388

Committed:
https://skia.googlesource.com/skia/+/c7a784cc8cb1c1dfcd39a32b2170ffe547904e9f
==========

[commit-bot: I haz the power, 2015-12-18 17:52:18]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c7a784cc8cb1c1dfcd39a32b2170ffe547904e9f