Move landmines into gyp_chromium

Move landmines into gyp_chromium

This ensures that the environment that's passed to gyp is the one that
landmines.py uses to determine when to set landmines.

Also, fix '2013e' not being detected as a 2013 switch.

BUG=309197, 323300
R=iannucci@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249242

[iannucci, 2014-02-05 23:47:50]

lgtm

https://codereview.chromium.org/153073004/diff/20001/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/153073004/diff/20001/build/gyp_chromium#newco...
build/gyp_chromium:496: [sys.executable, os.path.join(script_dir,
'landmines.py')])
Presumably 'args' doesn't contain any relevant goodies?

[scottmg, 2014-02-05 23:55:16]

https://codereview.chromium.org/153073004/diff/20001/build/gyp_chromium
File build/gyp_chromium (right):

https://codereview.chromium.org/153073004/diff/20001/build/gyp_chromium#newco...
build/gyp_chromium:496: [sys.executable, os.path.join(script_dir,
'landmines.py')])
On 2014/02/05 23:47:50, iannucci wrote:
> Presumably 'args' doesn't contain any relevant goodies?

Hm, good question. I think -Dgyp_output_dir is the only relevant one, but
landmines.py hardcodes that anyway. That's probably a bug, but also probably not
too urgent since it's sort of unsupported and not used on the bots (afaik?).

[scottmg, 2014-02-05 23:55:21]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2014-02-05 23:59:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/153073004/20001

[scottmg, 2014-02-06 02:45:03]

Committed patchset #2 manually as r249242 (presubmit successful).

[scottmg, 2014-02-06 03:17:49]

This seems to have correctly caused a clobber on the master.chromium.swarm bots
where I recently flipped the switch as a test:

http://build.chromium.org/p/chromium.swarm/builders/Windows%20Isolate%20Tests...

Setting clobber due to triggered landmines:
--- old_landmines	Sat Jan 18 13:27:12 2014
+++ new_landmines	Wed Feb 05 19:11:15 2014
@@ -2,0 +3 @@
+Switched win from VS2010 to VS2013.


\o/

[iannucci, 2014-02-06 03:26:42]

On 2014/02/06 03:17:49, scottmg wrote:
> This seems to have correctly caused a clobber on the master.chromium.swarm
bots
> where I recently flipped the switch as a test:
> 
>
http://build.chromium.org/p/chromium.swarm/builders/Windows%2520Isolate%2520T...
> 
> Setting clobber due to triggered landmines:
> --- old_landmines	Sat Jan 18 13:27:12 2014
> +++ new_landmines	Wed Feb 05 19:11:15 2014
> @@ -2,0 +3 @@
> +Switched win from VS2010 to VS2013.
> 
> 
> \o/

Winning!

[Nico, 2014-02-14 23:14:56]

This breaks ` GYP_GENERATORS=dump_dependency_json build/gyp_chromium`.

[scottmg, 2014-02-14 23:36:38]

On 2014/02/14 23:14:56, Nico (away Feb 11 - Feb 17) wrote:
> This breaks ` GYP_GENERATORS=dump_dependency_json build/gyp_chromium`.

Hmm, well, still works, but raises an annoying error. 

Coincidentally luken@ just noticed that this sort of breaks chromium.gyp_env
too, as both gyp_chromium and landmines.py apply, and then second application
prints a warning. I'll remove that from landmines.py.

[jochen (gone - plz use gerrit), 2014-06-04 11:01:13]

On 2014/02/14 23:36:38, scottmg wrote:
> On 2014/02/14 23:14:56, Nico (away Feb 11 - Feb 17) wrote:
> > This breaks ` GYP_GENERATORS=dump_dependency_json build/gyp_chromium`.
> 
> Hmm, well, still works, but raises an annoying error. 
> 
> Coincidentally luken@ just noticed that this sort of breaks chromium.gyp_env
> too, as both gyp_chromium and landmines.py apply, and then second application
> prints a warning. I'll remove that from landmines.py.

it also breaks landmines on all bots the define GYP_CHROMIUM_NO_ACTION