Move landmines into gyp_chromium

build/gyp_chromium

 #!/usr/bin/env python
 
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script is wrapper for Chromium that adds some support for how GYP
 # is invoked by Chromium beyond what can be done in the gclient hooks.
 
 import glob
@@ skipping 470 matching lines @@
       ['-I' + i for i in additional_include_files(supplemental_includes, args)])
 
   args.extend(['-D', 'gyp_output_dir=' + GetOutputDirectory()])
 
   print 'Updating projects from gyp files...'
   sys.stdout.flush()
 
   # Off we go...
   gyp_rc = gyp.main(args)
 
+  # Check for landmines (reasons to clobber the build). This must be run here,
+  # rather than a separate runhooks step so that any environment modifications
+  # from above are picked up.
+  print 'Running build/landmines.py...'
+  subprocess.check_call(
+      [sys.executable, os.path.join(script_dir, 'landmines.py')])

[iannucci, 2014/02/05 23:47:50]

Presumably 'args' doesn't contain any relevant goodies?

[scottmg, 2014/02/05 23:55:17]

Hm, good question. I think -Dgyp_output_dir is the only relevant one, but
landmines.py hardcodes that anyway. That's probably a bug, but also probably not
too urgent since it's sort of unsupported and not used on the bots (afaik?).

+
   if vs2013_runtime_dll_dirs:
     CopyVsRuntimeDlls(GetOutputDirectory(), vs2013_runtime_dll_dirs)
 
   sys.exit(gyp_rc)