Move landmines into gyp_chromium

build/gyp_chromium

Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index 30f1711c3764d6857a37001b7a3005d2998da772..9353752f6514d055058fd09507b688e067a0979f 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -488,6 +488,13 @@ if __name__ == '__main__':
   # Off we go...
   gyp_rc = gyp.main(args)
 
+  # Check for landmines (reasons to clobber the build). This must be run here,
+  # rather than a separate runhooks step so that any environment modifications
+  # from above are picked up.
+  print 'Running build/landmines.py...'
+  subprocess.check_call(
+      [sys.executable, os.path.join(script_dir, 'landmines.py')])

[iannucci, 2014/02/05 23:47:50]

Presumably 'args' doesn't contain any relevant goodies?

[scottmg, 2014/02/05 23:55:17]

Hm, good question. I think -Dgyp_output_dir is the only relevant one, but
landmines.py hardcodes that anyway. That's probably a bug, but also probably not
too urgent since it's sort of unsupported and not used on the bots (afaik?).

+
   if vs2013_runtime_dll_dirs:
     CopyVsRuntimeDlls(GetOutputDirectory(), vs2013_runtime_dll_dirs)