Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1530313005: Remove some unneeded calls to GrGLGpu::configToGLFormats (Closed)

Created:
5 years ago by bsalomon
Modified:
5 years ago
Reviewers:
jvanverth1, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@internalFormat
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M src/gpu/gl/GrGLGpu.cpp View 4 chunks +6 lines, -13 lines 1 comment Download

Depends on Patchset:

Issue 1532273002 Patch 20001

Dependent Patchsets:

Issue 1533903004 Patch 1

Messages

Total messages: 8 (4 generated)
bsalomon
Leaves only one caller (for render buffer format). https://codereview.chromium.org/1530313005/diff/1/src/gpu/gl/GrGLGpu.cpp File src/gpu/gl/GrGLGpu.cpp (right): https://codereview.chromium.org/1530313005/diff/1/src/gpu/gl/GrGLGpu.cpp#newcode416 src/gpu/gl/GrGLGpu.cpp:416: GrTexture* ...
5 years ago (2015-12-18 01:24:20 UTC) #3
egdaniel
lgtm
5 years ago (2015-12-18 01:38:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530313005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530313005/1
5 years ago (2015-12-18 02:18:25 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-18 02:39:50 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2555ee2e9940d00d0cc54772a934e7215d055ba2

Powered by Google App Engine
This is Rietveld 408576698