Add field for internalFormat param to glTexImage to GrGLGpu::ConfigEntry.

Add field for internalFormat param to glTexImage to GrGLGpu::ConfigEntry.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1532273002

Committed: https://skia.googlesource.com/skia/+/926cb023892378a2eb7c05fc0bce8650ec09ceb1

[bsalomon, 2015-12-18 00:49:52]

Description was changed from

==========
Add field for internalFormat param to glTexImage to GrGLGpu::ConfigEntry.
==========

to

==========
Add field for internalFormat param to glTexImage to GrGLGpu::ConfigEntry.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[bsalomon, 2015-12-18 01:02:28]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, jvanverth@google.com

[egdaniel, 2015-12-18 01:31:15]

lgtm with minor question

https://codereview.chromium.org/1532273002/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1532273002/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:1200: SkASSERT(this->caps()->isConfigRenderable(config,
false));
Do we know we will only get here for non-msaa?

[bsalomon, 2015-12-18 02:01:52]

https://codereview.chromium.org/1532273002/diff/20001/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1532273002/diff/20001/src/gpu/gl/GrGLGpu.cpp#...
src/gpu/gl/GrGLGpu.cpp:1200: SkASSERT(this->caps()->isConfigRenderable(config,
false));
On 2015/12/18 01:31:15, egdaniel wrote:
> Do we know we will only get here for non-msaa?

No, but we know that any msaa renderable format is also renderable without msaa
(and the code below uses a non-msaa color attachment).

[bsalomon, 2015-12-18 02:01:56]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-12-18 02:02:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1532273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1532273002/20001

[commit-bot: I haz the power, 2015-12-18 02:15:14]

Description was changed from

==========
Add field for internalFormat param to glTexImage to GrGLGpu::ConfigEntry.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Add field for internalFormat param to glTexImage to GrGLGpu::ConfigEntry.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/926cb023892378a2eb7c05fc0bce8650ec09ceb1
==========

[commit-bot: I haz the power, 2015-12-18 02:15:14]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/926cb023892378a2eb7c05fc0bce8650ec09ceb1