Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1530233004: add RBIT instruction to the ARM integrated assembler. (Closed)

Created:
5 years ago by Karl
Modified:
5 years ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update DART source. #

Total comments: 2

Patch Set 3 : Fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -29 lines) Patch
M src/DartARM32/assembler_arm.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 2 2 chunks +8 lines, -1 line 0 comments Download
M src/IceAssemblerARM32.cpp View 1 2 1 chunk +28 lines, -10 lines 0 comments Download
M src/IceInstARM32.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
A + tests_lit/assembler/arm32/rbit.ll View 1 2 2 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Karl
5 years ago (2015-12-17 18:31:42 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1530233004/diff/20001/tests_lit/assembler/arm32/rbit.ll File tests_lit/assembler/arm32/rbit.ll (right): https://codereview.chromium.org/1530233004/diff/20001/tests_lit/assembler/arm32/rbit.ll#newcode1 tests_lit/assembler/arm32/rbit.ll:1: ; Show that we know how to translate ...
5 years ago (2015-12-17 19:31:16 UTC) #4
Karl
Committed patchset #3 (id:40001) manually as 17fe1948d0318533db14f0334056c0bdf3b79c2d (presubmit successful).
5 years ago (2015-12-18 15:41:16 UTC) #6
Karl
5 years ago (2015-12-18 15:41:25 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/1530233004/diff/20001/tests_lit/assembler/arm...
File tests_lit/assembler/arm32/rbit.ll (right):

https://codereview.chromium.org/1530233004/diff/20001/tests_lit/assembler/arm...
tests_lit/assembler/arm32/rbit.ll:1: ; Show that we know how to translate add.
On 2015/12/17 19:31:16, stichnot wrote:
> rbit

Done.

Powered by Google App Engine
This is Rietveld 408576698