Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Issue 1530153003: MIPS: Fix enabling v8 compilation with CLANG. (Closed)

Created:
5 years ago by Ilija.Pavlovic1
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix enabling v8 compilation with CLANG. Updated toolchain.gypi to support v8 using CLANG on MIPS. These changes include using integrated assembler with CLANG, and disabling options used by GCC which are not supported by CLANG. Reland https://codereview.chromium.org/1519493002 with fix to remove duplicated 'conditions' sections. TEST= BUG= Committed: https://crrev.com/6dd99f19daa6ae9e7ad41e5b46294636b524c205 Cr-Commit-Position: refs/heads/master@{#32963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -11 lines) Patch
M build/toolchain.gypi View 10 chunks +65 lines, -11 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Ilija.Pavlovic1
5 years ago (2015-12-16 15:39:19 UTC) #2
paul.l...
provisional lgtm to get trybots working.
5 years ago (2015-12-16 16:05:05 UTC) #3
Jakob Kummerow
LGTM. Best practice for relands is to upload the original patch as the first patch ...
5 years ago (2015-12-16 16:16:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530153003/1
5 years ago (2015-12-16 16:17:06 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530153003/1
5 years ago (2015-12-16 16:54:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530153003/1
5 years ago (2015-12-18 07:40:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-18 08:02:40 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-18 08:03:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6dd99f19daa6ae9e7ad41e5b46294636b524c205
Cr-Commit-Position: refs/heads/master@{#32963}

Powered by Google App Engine
This is Rietveld 408576698