Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1519493002: MIPS: Enable v8 compilation with CLANG. (Closed)

Created:
5 years ago by Ilija.Pavlovic1
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Enable v8 compilation with CLANG. Updated toolchain.gypi to support v8 using CLANG on MIPS. These changes include using integrated assembler with CLANG, and disabling options used by GCC which are not supported by CLANG. TEST= BUG= Committed: https://crrev.com/0bae3c393575de4503cb179faa220e597e35dd8f Cr-Commit-Position: refs/heads/master@{#32780}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -11 lines) Patch
M build/toolchain.gypi View 10 chunks +69 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Ilija.Pavlovic1
5 years ago (2015-12-10 13:37:18 UTC) #2
balazs.kilvady
lgtm. I guess we need an lgtm from a google guy, maybe Jakob is a ...
5 years ago (2015-12-10 14:51:42 UTC) #3
Jakob Kummerow
lgtm
5 years ago (2015-12-10 16:14:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1519493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1519493002/1
5 years ago (2015-12-11 07:28:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 08:07:15 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0bae3c393575de4503cb179faa220e597e35dd8f Cr-Commit-Position: refs/heads/master@{#32780}
5 years ago (2015-12-11 08:07:58 UTC) #10
Michael Achenbach
5 years ago (2015-12-11 09:10:02 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1520823002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] This seems to break chromium runhooks for
android:
https://build.chromium.org/p/client.v8.fyi/builders/Android%20Builder/builds/....

Powered by Google App Engine
This is Rietveld 408576698