Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2764)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java

Issue 1530123002: Prepare ClearBrowsingDataDialogFragment for browsing data counters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@utils
Patch Set: Added *Bridge class, shared enum Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
index 40df78393c3ef9b671dfb7bf001cccb58f1d663b..8c151142d847ef1476694c6fb28f488b3f45f803 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java
@@ -631,18 +631,24 @@ public final class PrefServiceBridge {
public abstract void onBrowsingDataCleared();
}
+ public boolean getBrowsingDataDeletionPreference(int dataType) {
newt (away) 2016/01/12 18:55:26 public methods need javadoc.
msramek 2016/01/13 15:27:53 Done. (Hmm, there is a presubmit warning for class
newt (away) 2016/01/13 20:01:49 We haven't enabled the presubmit warning for metho
+ return nativeGetBrowsingDataDeletionPreference(dataType);
+ }
+
+ public void setBrowsingDataDeletionPreference(int dataType, boolean value) {
newt (away) 2016/01/12 18:55:26 javadoc
msramek 2016/01/13 15:27:53 Done.
+ nativeSetBrowsingDataDeletionPreference(dataType, value);
+ }
+
/**
* Clear the specified types of browsing data asynchronously.
newt (away) 2016/01/12 18:55:26 Explain what the valid values for dataTypes are
msramek 2016/01/13 15:27:53 Done.
* |listener| is an object to be notified when clearing completes.
* It can be null, but many operations (e.g. navigation) are
* ill-advised while browsing data is being cleared.
*/
- public void clearBrowsingData(OnClearBrowsingDataListener listener,
- boolean history, boolean cache, boolean cookiesAndSiteData,
- boolean passwords, boolean formData) {
+ public void clearBrowsingData(OnClearBrowsingDataListener listener, int[] dataTypes) {
assert mClearBrowsingDataListener == null;
mClearBrowsingDataListener = listener;
- nativeClearBrowsingData(history, cache, cookiesAndSiteData, passwords, formData);
+ nativeClearBrowsingData(dataTypes);
}
/*
@@ -970,8 +976,9 @@ public final class PrefServiceBridge {
private native void nativeResetTranslateDefaults();
private native void nativeMigrateJavascriptPreference();
private native void nativeSetJavaScriptAllowed(String pattern, int setting);
- private native void nativeClearBrowsingData(boolean history, boolean cache,
- boolean cookiesAndSiteData, boolean passwords, boolean formData);
+ private native boolean nativeGetBrowsingDataDeletionPreference(int dataType);
+ private native void nativeSetBrowsingDataDeletionPreference(int dataType, boolean value);
+ private native void nativeClearBrowsingData(int[] dataTypes);
private native boolean nativeCanDeleteBrowsingHistory();
private native void nativeSetAllowCookiesEnabled(boolean allow);
private native void nativeSetBlockThirdPartyCookiesEnabled(boolean enabled);

Powered by Google App Engine
This is Rietveld 408576698