Prepare ClearBrowsingDataDialogFragment for browsing data counters.

chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.preferences;
 
 import android.content.Context;
 import android.content.SharedPreferences;
 import android.preference.PreferenceManager;
 import android.util.Log;
@@ skipping 613 matching lines @@
         nativeSetResolveNavigationErrorEnabled(enabled);
     }
 
     /**
      * Interface for a class that is listening to clear browser data events.
      */
     public interface OnClearBrowsingDataListener {
         public abstract void onBrowsingDataCleared();
     }
 
+    public boolean getBrowsingDataDeletionPreference(int dataType) {

[newt (away), 2016/01/12 18:55:26]

public methods need javadoc.

[msramek, 2016/01/13 15:27:53]

Done. (Hmm, there is a presubmit warning for class javadoc, but apparently none
for methods; and it's missing for a lot of methods in this file!)

[newt (away), 2016/01/13 20:01:49]

We haven't enabled the presubmit warning for methods (yet) because there are too
many methods still missing javadocs, and checkstyle checks the entire class for
issues, not just the changed lines. Thank you for helping to reduce the number
of methods missing javadoc :)

+        return nativeGetBrowsingDataDeletionPreference(dataType);
+    }
+
+    public void setBrowsingDataDeletionPreference(int dataType, boolean value) {

[newt (away), 2016/01/12 18:55:26]

javadoc

[msramek, 2016/01/13 15:27:53]

Done.

+        nativeSetBrowsingDataDeletionPreference(dataType, value);
+    }
+
     /**
      * Clear the specified types of browsing data asynchronously.

[newt (away), 2016/01/12 18:55:26]

Explain what the valid values for dataTypes are

[msramek, 2016/01/13 15:27:53]

Done.

      * |listener| is an object to be notified when clearing completes.
      * It can be null, but many operations (e.g. navigation) are
      * ill-advised while browsing data is being cleared.
      */
-    public void clearBrowsingData(OnClearBrowsingDataListener listener,
-            boolean history, boolean cache, boolean cookiesAndSiteData,
-            boolean passwords, boolean formData) {
+    public void clearBrowsingData(OnClearBrowsingDataListener listener, int[] dataTypes) {
         assert mClearBrowsingDataListener == null;
         mClearBrowsingDataListener = listener;
-        nativeClearBrowsingData(history, cache, cookiesAndSiteData, passwords, formData);
+        nativeClearBrowsingData(dataTypes);
     }
 
     /*
      * Whether browser history can be deleted by the user.
      */
     public boolean canDeleteBrowsingHistory() {
         return nativeCanDeleteBrowsingHistory();
     }
 
     @CalledByNative
@@ skipping 307 matching lines @@
     private native boolean nativeGetIncognitoModeEnabled();
     private native boolean nativeGetIncognitoModeManaged();
     private native boolean nativeGetPrintingEnabled();
     private native boolean nativeGetPrintingManaged();
     private native boolean nativeGetSupervisedUserSafeSitesEnabled();
     private native void nativeSetTranslateEnabled(boolean enabled);
     private native void nativeSetAutoDetectEncodingEnabled(boolean enabled);
     private native void nativeResetTranslateDefaults();
     private native void nativeMigrateJavascriptPreference();
     private native void nativeSetJavaScriptAllowed(String pattern, int setting);
-    private native void nativeClearBrowsingData(boolean history, boolean cache,
-            boolean cookiesAndSiteData, boolean passwords, boolean formData);
+    private native boolean nativeGetBrowsingDataDeletionPreference(int dataType);
+    private native void nativeSetBrowsingDataDeletionPreference(int dataType, boolean value);
+    private native void nativeClearBrowsingData(int[] dataTypes);
     private native boolean nativeCanDeleteBrowsingHistory();
     private native void nativeSetAllowCookiesEnabled(boolean allow);
     private native void nativeSetBlockThirdPartyCookiesEnabled(boolean enabled);
     private native void nativeSetDoNotTrackEnabled(boolean enabled);
     private native void nativeSetFullscreenAllowed(boolean allowed);
     private native void nativeSetRememberPasswordsEnabled(boolean allow);
     private native void nativeSetPasswordManagerAutoSigninEnabled(boolean enabled);
     private native void nativeSetProtectedMediaIdentifierEnabled(boolean enabled);
     private native boolean nativeGetAllowLocationEnabled();
     private native boolean nativeGetPushNotificationsEnabled();
@@ skipping 33 matching lines @@
     private native String nativeGetSupervisedUserSecondCustodianName();
     private native String nativeGetSupervisedUserSecondCustodianEmail();
     private native String nativeGetSupervisedUserSecondCustodianProfileImageURL();
     private native boolean nativeGetMetricsReportingEnabled();
     private native void nativeSetMetricsReportingEnabled(boolean enabled);
     private native boolean nativeHasSetMetricsReporting();
     private native void nativeSetClickedUpdateMenuItem(boolean clicked);
     private native boolean nativeGetClickedUpdateMenuItem();
     private native void nativeSetSupervisedUserId(String supervisedUserId);
 }