Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2107)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/BrowsingDataCounterBridge.java

Issue 1530123002: Prepare ClearBrowsingDataDialogFragment for browsing data counters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@utils
Patch Set: Added *Bridge class, shared enum Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/BrowsingDataCounterBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/BrowsingDataCounterBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/BrowsingDataCounterBridge.java
new file mode 100644
index 0000000000000000000000000000000000000000..3c0a6553077b895b5506230737d5926a2f5bf1a2
--- /dev/null
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/BrowsingDataCounterBridge.java
@@ -0,0 +1,34 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.chrome.browser.preferences.privacy;
+
+import org.chromium.base.annotations.CalledByNative;
+
+/**
+ * Communicates between BrowsingDataCounter (C++ backend) and ClearBrowsingDataFragment (Java UI).
+ */
+public class BrowsingDataCounterBridge {
+ private final long mNativeBrowsingDataCounterBridge;
+ private BrowsingDataCounterCallback mOwner;
newt (away) 2016/01/12 18:55:26 I'd be consistent with terminology and rename mOwn
msramek 2016/01/13 15:27:53 Done.
+
+ public BrowsingDataCounterBridge(BrowsingDataCounterCallback owner, int dataType) {
newt (away) 2016/01/12 18:55:26 javadoc for all public methods
msramek 2016/01/13 15:27:53 Done.
+ mOwner = owner;
+ mNativeBrowsingDataCounterBridge = nativeInit(dataType);
+ }
+
+ public void destroy() {
+ if (mNativeBrowsingDataCounterBridge != 0) {
+ nativeDestroy(mNativeBrowsingDataCounterBridge);
newt (away) 2016/01/12 18:55:26 set mNativeBrowsingDataCounterBridge to 0 after de
msramek 2016/01/13 15:27:53 Done.
+ }
+ }
+
+ @CalledByNative
+ private void onBrowsingDataCounterFinished(String result) {
+ mOwner.onCounterFinished(result);
+ }
+
+ private native long nativeInit(int index);
newt (away) 2016/01/12 18:55:26 s/index/dataType/
msramek 2016/01/13 15:27:53 Done.
+ private static native void nativeDestroy(long nativeBrowsingDataCounterBridge);
newt (away) 2016/01/12 18:55:26 make this non-static
msramek 2016/01/13 15:27:53 Done.
+}

Powered by Google App Engine
This is Rietveld 408576698