Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1523843003: Add for loop to asm-to-wasm (Closed)

Created:
5 years ago by aseemgarg
Modified:
4 years, 9 months ago
Reviewers:
titzer, bradnelson, bradn, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add for loop to asm-to-wasm TEST=asm-wasm.js R=titzer@chromium.org,bradnelson@google.com BUG= Committed: https://crrev.com/1c8130bd89d41536669ac0529bf2340f8e8ad405 Cr-Commit-Position: refs/heads/master@{#32895}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -1 line) Patch
M src/wasm/asm-wasm-builder.cc View 1 chunk +24 lines, -1 line 1 comment Download
M test/mjsunit/wasm/asm-wasm.js View 1 chunk +85 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (10 generated)
aseemgarg
5 years ago (2015-12-15 00:20:44 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523843003/1
5 years ago (2015-12-15 00:21:57 UTC) #3
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years ago (2015-12-15 00:22:00 UTC) #5
bradnelson
lgtm https://codereview.chromium.org/1523843003/diff/1/src/wasm/asm-wasm-builder.cc File src/wasm/asm-wasm-builder.cc (right): https://codereview.chromium.org/1523843003/diff/1/src/wasm/asm-wasm-builder.cc#newcode264 src/wasm/asm-wasm-builder.cc:264: void VisitForInStatement(ForInStatement* stmt) { Unrelated to this CL, ...
5 years ago (2015-12-15 03:07:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523843003/1
5 years ago (2015-12-15 03:07:12 UTC) #9
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-15 03:07:13 UTC) #11
bradn
lgtm
5 years ago (2015-12-15 03:09:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523843003/1
5 years ago (2015-12-15 03:10:02 UTC) #14
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years ago (2015-12-15 03:10:04 UTC) #16
ahaas
lgtm
5 years ago (2015-12-16 11:48:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523843003/1
5 years ago (2015-12-16 11:50:09 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 12:10:19 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-16 12:10:42 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c8130bd89d41536669ac0529bf2340f8e8ad405
Cr-Commit-Position: refs/heads/master@{#32895}

Powered by Google App Engine
This is Rietveld 408576698