Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1529913002: Parse list-style shorthand in CSSPropertyParser with CSSParserTokens (Closed)

Created:
5 years ago by rwlbuis
Modified:
5 years ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Parse list-style shorthand in CSSPropertyParser with CSSParserTokens Move list-style property handling from LegacyCSSPropertyParser into CSSPropertyParser. Also move its related longhands. BUG=499780 Committed: https://crrev.com/b35c553620dce166c62f02859ec158ebef19c63f Cr-Commit-Position: refs/heads/master@{#365438}

Patch Set 1 #

Patch Set 2 : V2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 1 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
rwlbuis
PTAL. Hopefully this helps regarding the issue from the spreadsheet: ~~move fastpath keyword callsite into ...
5 years ago (2015-12-15 21:56:49 UTC) #3
Timothy Loh
lgtm On 2015/12/15 21:56:49, rwlbuis wrote: > PTAL. Hopefully this helps regarding the issue from ...
5 years ago (2015-12-16 00:21:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529913002/20001
5 years ago (2015-12-16 00:40:35 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years ago (2015-12-16 02:48:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1529913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1529913002/20001
5 years ago (2015-12-16 03:21:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-16 04:19:18 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-16 04:20:49 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b35c553620dce166c62f02859ec158ebef19c63f
Cr-Commit-Position: refs/heads/master@{#365438}

Powered by Google App Engine
This is Rietveld 408576698