Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1442)

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1529913002: Parse list-style shorthand in CSSPropertyParser with CSSParserTokens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: V2 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
index 0aea3c6397d8fe6c678db53c196ec58e6ff06a7e..0763e24d3443f9c44f3d0fd930474a2d5e42a947 100644
--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp
@@ -393,8 +393,7 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
m_implicitShorthand = false;
return result;
}
- case CSSPropertyListStyleImage: // <uri> | none | inherit
- case CSSPropertyBorderImageSource:
+ case CSSPropertyBorderImageSource: // <uri> | none | inherit
case CSSPropertyWebkitMaskBoxImageSource:
if (parseFillImage(m_valueList, parsedValue))
m_valueList->next();
@@ -663,8 +662,6 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
case CSSPropertyBorderStyle:
// <border-style>{1,4} | inherit
return parse4Values(propId, borderStyleShorthand().properties(), important);
- case CSSPropertyListStyle:
- return parseShorthand(propId, listStyleShorthand(), important);
case CSSPropertyInvalid:
return false;
case CSSPropertyWebkitClipPath:
@@ -887,6 +884,8 @@ bool CSSPropertyParser::parseValue(CSSPropertyID unresolvedProperty, bool import
case CSSPropertyCursor:
case CSSPropertyTransformOrigin:
case CSSPropertyContent:
+ case CSSPropertyListStyleImage:
+ case CSSPropertyListStyle:
validPrimitive = false;
break;
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698