Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Side by Side Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1529913002: Parse list-style shorthand in CSSPropertyParser with CSSParserTokens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: V2 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com> 5 * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org> 6 * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved. 8 * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
9 * Copyright (C) 2012 Intel Corporation. All rights reserved. 9 * Copyright (C) 2012 Intel Corporation. All rights reserved.
10 * 10 *
(...skipping 375 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 } else { 386 } else {
387 addProperty(propId1, val1.release(), important); 387 addProperty(propId1, val1.release(), important);
388 if (val2) 388 if (val2)
389 addProperty(propId2, val2.release(), important); 389 addProperty(propId2, val2.release(), important);
390 } 390 }
391 result = true; 391 result = true;
392 } 392 }
393 m_implicitShorthand = false; 393 m_implicitShorthand = false;
394 return result; 394 return result;
395 } 395 }
396 case CSSPropertyListStyleImage: // <uri> | none | inherit 396 case CSSPropertyBorderImageSource: // <uri> | none | inherit
397 case CSSPropertyBorderImageSource:
398 case CSSPropertyWebkitMaskBoxImageSource: 397 case CSSPropertyWebkitMaskBoxImageSource:
399 if (parseFillImage(m_valueList, parsedValue)) 398 if (parseFillImage(m_valueList, parsedValue))
400 m_valueList->next(); 399 m_valueList->next();
401 break; 400 break;
402 401
403 case CSSPropertyBorderTopWidth: //// <border-width> | inherit 402 case CSSPropertyBorderTopWidth: //// <border-width> | inherit
404 case CSSPropertyBorderRightWidth: // Which is defined as 403 case CSSPropertyBorderRightWidth: // Which is defined as
405 case CSSPropertyBorderBottomWidth: // thin | medium | thick | <length> 404 case CSSPropertyBorderBottomWidth: // thin | medium | thick | <length>
406 case CSSPropertyBorderLeftWidth: 405 case CSSPropertyBorderLeftWidth:
407 if (!inShorthand() || m_currentShorthand == CSSPropertyBorderWidth) 406 if (!inShorthand() || m_currentShorthand == CSSPropertyBorderWidth)
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
656 return parseShorthand(propId, borderLeftShorthand(), important); 655 return parseShorthand(propId, borderLeftShorthand(), important);
657 case CSSPropertyBorderColor: 656 case CSSPropertyBorderColor:
658 // <color>{1,4} | inherit 657 // <color>{1,4} | inherit
659 return parse4Values(propId, borderColorShorthand().properties(), importa nt); 658 return parse4Values(propId, borderColorShorthand().properties(), importa nt);
660 case CSSPropertyBorderWidth: 659 case CSSPropertyBorderWidth:
661 // <border-width>{1,4} | inherit 660 // <border-width>{1,4} | inherit
662 return parse4Values(propId, borderWidthShorthand().properties(), importa nt); 661 return parse4Values(propId, borderWidthShorthand().properties(), importa nt);
663 case CSSPropertyBorderStyle: 662 case CSSPropertyBorderStyle:
664 // <border-style>{1,4} | inherit 663 // <border-style>{1,4} | inherit
665 return parse4Values(propId, borderStyleShorthand().properties(), importa nt); 664 return parse4Values(propId, borderStyleShorthand().properties(), importa nt);
666 case CSSPropertyListStyle:
667 return parseShorthand(propId, listStyleShorthand(), important);
668 case CSSPropertyInvalid: 665 case CSSPropertyInvalid:
669 return false; 666 return false;
670 case CSSPropertyWebkitClipPath: 667 case CSSPropertyWebkitClipPath:
671 if (id == CSSValueNone) { 668 if (id == CSSValueNone) {
672 validPrimitive = true; 669 validPrimitive = true;
673 } else if (value->m_unit == CSSParserValue::Function) { 670 } else if (value->m_unit == CSSParserValue::Function) {
674 parsedValue = parseBasicShape(); 671 parsedValue = parseBasicShape();
675 } else if (value->m_unit == CSSParserValue::URI) { 672 } else if (value->m_unit == CSSParserValue::URI) {
676 parsedValue = CSSURIValue::create(value->string); 673 parsedValue = CSSURIValue::create(value->string);
677 addProperty(propId, parsedValue.release(), important); 674 addProperty(propId, parsedValue.release(), important);
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
880 case CSSPropertyX: 877 case CSSPropertyX:
881 case CSSPropertyY: 878 case CSSPropertyY:
882 case CSSPropertyR: 879 case CSSPropertyR:
883 case CSSPropertyRx: 880 case CSSPropertyRx:
884 case CSSPropertyRy: 881 case CSSPropertyRy:
885 case CSSPropertyScale: 882 case CSSPropertyScale:
886 case CSSPropertyTranslate: 883 case CSSPropertyTranslate:
887 case CSSPropertyCursor: 884 case CSSPropertyCursor:
888 case CSSPropertyTransformOrigin: 885 case CSSPropertyTransformOrigin:
889 case CSSPropertyContent: 886 case CSSPropertyContent:
887 case CSSPropertyListStyleImage:
888 case CSSPropertyListStyle:
890 validPrimitive = false; 889 validPrimitive = false;
891 break; 890 break;
892 891
893 case CSSPropertyScrollSnapPointsX: 892 case CSSPropertyScrollSnapPointsX:
894 case CSSPropertyScrollSnapPointsY: 893 case CSSPropertyScrollSnapPointsY:
895 parsedValue = parseScrollSnapPoints(); 894 parsedValue = parseScrollSnapPoints();
896 break; 895 break;
897 case CSSPropertyScrollSnapCoordinate: 896 case CSSPropertyScrollSnapCoordinate:
898 parsedValue = parseScrollSnapCoordinate(); 897 parsedValue = parseScrollSnapCoordinate();
899 break; 898 break;
(...skipping 3882 matching lines...) Expand 10 before | Expand all | Expand 10 after
4782 ASSERT(!m_parsedCalculation); 4781 ASSERT(!m_parsedCalculation);
4783 m_parsedCalculation = CSSCalcValue::create(args, range); 4782 m_parsedCalculation = CSSCalcValue::create(args, range);
4784 4783
4785 if (!m_parsedCalculation) 4784 if (!m_parsedCalculation)
4786 return false; 4785 return false;
4787 4786
4788 return true; 4787 return true;
4789 } 4788 }
4790 4789
4791 } // namespace blink 4790 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698