Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: Source/core/dom/CharacterData.h

Issue 152983002: Devirtualize offsetInCharacters (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase against ToT Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/dom/CharacterData.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009 Apple Inc. All rights reserv ed.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 }; 70 };
71 void didModifyData(const String& oldValue, UpdateSource); 71 void didModifyData(const String& oldValue, UpdateSource);
72 72
73 String m_data; 73 String m_data;
74 74
75 private: 75 private:
76 virtual String nodeValue() const override final; 76 virtual String nodeValue() const override final;
77 virtual void setNodeValue(const String&) override final; 77 virtual void setNodeValue(const String&) override final;
78 virtual bool isCharacterDataNode() const override final { return true; } 78 virtual bool isCharacterDataNode() const override final { return true; }
79 virtual int maxCharacterOffset() const override final; 79 virtual int maxCharacterOffset() const override final;
80 virtual bool offsetInCharacters() const override final;
81 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, UpdateSource = UpdateFromNonParser, RecalcStyleB ehavior = DoNotRecalcStyle); 80 void setDataAndUpdate(const String&, unsigned offsetOfReplacedData, unsigned oldLength, unsigned newLength, UpdateSource = UpdateFromNonParser, RecalcStyleB ehavior = DoNotRecalcStyle);
82 81
83 bool isContainerNode() const = delete; // This will catch anyone doing an un necessary check. 82 bool isContainerNode() const = delete; // This will catch anyone doing an un necessary check.
84 bool isElementNode() const = delete; // This will catch anyone doing an unne cessary check. 83 bool isElementNode() const = delete; // This will catch anyone doing an unne cessary check.
85 }; 84 };
86 85
87 DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode()); 86 DEFINE_NODE_TYPE_CASTS(CharacterData, isCharacterDataNode());
88 87
89 } // namespace blink 88 } // namespace blink
90 89
91 #endif // CharacterData_h 90 #endif // CharacterData_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/CharacterData.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698