Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Unified Diff: mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl

Issue 1529093004: [mojo] Suppress findbugs errors on generated bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/java/BUILD.gn ('k') | mojo/public/tools/bindings/generators/java_templates/header.java.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl
diff --git a/mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl b/mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl
index cd4ee86ea18919b547e47627e8df5ae7ada22416..34170a372d8ad2dcfe2a4f70ee153fb3efed5c45 100644
--- a/mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl
+++ b/mojo/public/tools/bindings/generators/java_templates/data_types_definition.tmpl
@@ -261,11 +261,17 @@ public final class {{union|name}} extends org.chromium.mojo.bindings.Union {
}
{% for field in union.fields %}
+ // TODO(rockot): Fix the findbugs error and remove this suppression.
+ // See http://crbug.com/570386.
+ @SuppressFBWarnings("EI_EXPOSE_REP2")
public void set{{field|ucc}}({{field.kind|java_type}} {{field|name}}) {
mTag_ = {{field.ordinal}};
m{{field|ucc}} = {{field|name}};
}
+ // TODO(rockot): Fix the findbugs error and remove this suppression.
+ // See http://crbug.com/570386.
+ @SuppressFBWarnings("EI_EXPOSE_REP")
public {{field.kind|java_type}} get{{field|ucc}}() {
assert mTag_ == {{field.ordinal}};
return m{{field|ucc}};
« no previous file with comments | « mojo/public/java/BUILD.gn ('k') | mojo/public/tools/bindings/generators/java_templates/header.java.tmpl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698