[turbofan] Flatten cons strings before embedding them into optimized code.

[turbofan] Flatten cons strings before embedding them into optimized code.

Flatten ConsString objects in JSGraph, to make sure we consistently
flatten all cons strings no matter which pass creates them.

R=yangguo@chromium.org

Committed: https://crrev.com/f910ed8e2185ffd781f03deb9742e241a7668118
Cr-Commit-Position: refs/heads/master@{#32878}

[Benedikt Meurer, 2015-12-16 06:22:02]

Hey Yang,

Simple follow up CL.
Please take a look.

Thanks,
Benedikt

[Yang, 2015-12-16 06:24:16]

lgtm.

https://codereview.chromium.org/1529053003/diff/1/src/compiler/js-graph.cc
File src/compiler/js-graph.cc (right):

https://codereview.chromium.org/1529053003/diff/1/src/compiler/js-graph.cc#ne...
src/compiler/js-graph.cc:75: if (value->IsConsString()) {
String::Flatten already checks for cons string. No need to do it here.

[Benedikt Meurer, 2015-12-16 06:26:02]

https://codereview.chromium.org/1529053003/diff/1/src/compiler/js-graph.cc
File src/compiler/js-graph.cc (right):

https://codereview.chromium.org/1529053003/diff/1/src/compiler/js-graph.cc#ne...
src/compiler/js-graph.cc:75: if (value->IsConsString()) {
That doesn't really help, since we'd have to test for string at least :-)

[Benedikt Meurer, 2015-12-16 06:26:11]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2015-12-16 06:26:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1529053003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1529053003/1

[commit-bot: I haz the power, 2015-12-16 06:42:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-12-16 06:42:56]

Description was changed from

==========
[turbofan] Flatten cons strings before embedding them into optimized code.

Flatten ConsString objects in JSGraph, to make sure we consistently
flatten all cons strings no matter which pass creates them.

R=yangguo@chromium.org
==========

to

==========
[turbofan] Flatten cons strings before embedding them into optimized code.

Flatten ConsString objects in JSGraph, to make sure we consistently
flatten all cons strings no matter which pass creates them.

R=yangguo@chromium.org

Committed: https://crrev.com/f910ed8e2185ffd781f03deb9742e241a7668118
Cr-Commit-Position: refs/heads/master@{#32878}
==========

[commit-bot: I haz the power, 2015-12-16 06:42:56]

Patchset 1 (id:??) landed as
https://crrev.com/f910ed8e2185ffd781f03deb9742e241a7668118
Cr-Commit-Position: refs/heads/master@{#32878}