Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: src/compiler/js-context-specialization.cc

Issue 1529053003: [turbofan] Flatten cons strings before embedding them into optimized code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@HeapConstants
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/js-frame-specialization.cc » ('j') | src/compiler/js-graph.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/js-context-specialization.cc
diff --git a/src/compiler/js-context-specialization.cc b/src/compiler/js-context-specialization.cc
index 8bbfe1e9498ddf1750408b620e2ebfbe55b17c60..4d9d1d950412321d03cefc884a1f3e6d47476f9d 100644
--- a/src/compiler/js-context-specialization.cc
+++ b/src/compiler/js-context-specialization.cc
@@ -77,9 +77,6 @@ Reduction JSContextSpecialization::ReduceJSLoadContext(Node* node) {
// Success. The context load can be replaced with the constant.
// TODO(titzer): record the specialization for sharing code across multiple
// contexts that have the same value in the corresponding context slot.
- if (value->IsConsString()) {
- value = String::Flatten(Handle<String>::cast(value), TENURED);
- }
Node* constant = jsgraph_->Constant(value);
ReplaceWithValue(node, constant);
return Replace(constant);
« no previous file with comments | « no previous file | src/compiler/js-frame-specialization.cc » ('j') | src/compiler/js-graph.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698