Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1523323005: [turbofan] Implement proper caching of heap constants in the JSGraph. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implement proper caching of heap constants in the JSGraph. With the handle canonicalization we can now easily cache heap constant nodes based on the location of the HeapObject handle location. R=yangguo@chromium.org Committed: https://crrev.com/7b59723d68f21710e41721854a65f0a77cc13b7a Cr-Commit-Position: refs/heads/master@{#32876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -24 lines) Patch
M src/compiler/common-node-cache.h View 3 chunks +7 lines, -1 line 0 comments Download
M src/compiler/common-node-cache.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/js-graph.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-graph.cc View 3 chunks +14 lines, -22 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-16 05:51:43 UTC) #1
Benedikt Meurer
Hey Yang, Handle canonicalization pays off. :-) Please take a look. Thanks, Benedikt
5 years ago (2015-12-16 05:53:26 UTC) #2
Yang
On 2015/12/16 05:53:26, Benedikt Meurer wrote: > Hey Yang, > > Handle canonicalization pays off. ...
5 years ago (2015-12-16 06:22:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1523323005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1523323005/1
5 years ago (2015-12-16 06:23:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 06:24:19 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-16 06:25:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7b59723d68f21710e41721854a65f0a77cc13b7a
Cr-Commit-Position: refs/heads/master@{#32876}

Powered by Google App Engine
This is Rietveld 408576698