Source/core/dom/DocumentSharedObjectPool.cpp - Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DocumentSharedObjectPool.cpp

Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/CSSSegmentedFontFace.cpp ('K') | « Source/core/css/RuleSet.cpp ('k') | Source/core/dom/PresentationAttributeStyle.cpp » ('j') | Source/core/dom/PresentationAttributeStyle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/DocumentSharedObjectPool.cpp

diff --git a/Source/core/dom/DocumentSharedObjectPool.cpp b/Source/core/dom/DocumentSharedObjectPool.cpp

index e278979278b1e19cd81c10004d16f80a4614ec8a..9d8bd7838beb359f5996cb8ece71295f82da4168 100644

--- a/Source/core/dom/DocumentSharedObjectPool.cpp

+++ b/Source/core/dom/DocumentSharedObjectPool.cpp

@@ -47,7 +47,7 @@ PassRefPtr<ShareableElementData> DocumentSharedObjectPool::cachedShareableElemen

{

ASSERT(!attributes.isEmpty());

- ShareableElementDataCache::iterator it = m_shareableElementDataCache.add(attributeHash(attributes), 0).iterator;

+ ShareableElementDataCache::ValueType* it = m_shareableElementDataCache.add(attributeHash(attributes), 0).iterator;

// FIXME: This prevents sharing when there's a hash collision.

if (it->value && !hasSameAttributes(attributes, *it->value))