Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: Source/core/dom/DocumentSharedObjectPool.cpp

Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, 2013 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2012, 2013 Apple Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 29 matching lines...) Expand all
40 { 40 {
41 if (attributes.size() != elementData.length()) 41 if (attributes.size() != elementData.length())
42 return false; 42 return false;
43 return !memcmp(attributes.data(), elementData.m_attributeArray, attributes.s ize() * sizeof(Attribute)); 43 return !memcmp(attributes.data(), elementData.m_attributeArray, attributes.s ize() * sizeof(Attribute));
44 } 44 }
45 45
46 PassRefPtr<ShareableElementData> DocumentSharedObjectPool::cachedShareableElemen tDataWithAttributes(const Vector<Attribute>& attributes) 46 PassRefPtr<ShareableElementData> DocumentSharedObjectPool::cachedShareableElemen tDataWithAttributes(const Vector<Attribute>& attributes)
47 { 47 {
48 ASSERT(!attributes.isEmpty()); 48 ASSERT(!attributes.isEmpty());
49 49
50 ShareableElementDataCache::iterator it = m_shareableElementDataCache.add(att ributeHash(attributes), 0).iterator; 50 ShareableElementDataCache::ValueType* it = m_shareableElementDataCache.add(a ttributeHash(attributes), 0).iterator;
51 51
52 // FIXME: This prevents sharing when there's a hash collision. 52 // FIXME: This prevents sharing when there's a hash collision.
53 if (it->value && !hasSameAttributes(attributes, *it->value)) 53 if (it->value && !hasSameAttributes(attributes, *it->value))
54 return ShareableElementData::createWithAttributes(attributes); 54 return ShareableElementData::createWithAttributes(attributes);
55 55
56 if (!it->value) 56 if (!it->value)
57 it->value = ShareableElementData::createWithAttributes(attributes); 57 it->value = ShareableElementData::createWithAttributes(attributes);
58 58
59 return it->value.get(); 59 return it->value.get();
60 } 60 }
61 61
62 DocumentSharedObjectPool::DocumentSharedObjectPool() 62 DocumentSharedObjectPool::DocumentSharedObjectPool()
63 { 63 {
64 } 64 }
65 65
66 DocumentSharedObjectPool::~DocumentSharedObjectPool() 66 DocumentSharedObjectPool::~DocumentSharedObjectPool()
67 { 67 {
68 } 68 }
69 69
70 } 70 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698