Source/core/css/RuleSet.cpp - Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/RuleSet.cpp

Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/css/CSSSegmentedFontFace.cpp ('K') | « Source/core/css/CSSSegmentedFontFace.cpp ('k') | Source/core/dom/DocumentSharedObjectPool.cpp » ('j') | Source/core/dom/PresentationAttributeStyle.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/RuleSet.cpp

diff --git a/Source/core/css/RuleSet.cpp b/Source/core/css/RuleSet.cpp

index d1b2c10c22e35526ea78d57781bef785f49028ae..6a2de10232a72692310c11844ae88bcfd6b9f041 100644

--- a/Source/core/css/RuleSet.cpp

+++ b/Source/core/css/RuleSet.cpp

@@ -390,7 +390,7 @@ void RuleSet::compactPendingRules(PendingRuleMap& pendingMap, CompactRuleMap& co

PendingRuleMap::iterator end = pendingMap.end();

for (PendingRuleMap::iterator it = pendingMap.begin(); it != end; ++it) {

OwnPtr<LinkedStack<RuleData> > pendingRules = it->value.release();

- CompactRuleMap::iterator compactRules = compactMap.add(it->key, nullptr).iterator;

+ CompactRuleMap::ValueType* compactRules = compactMap.add(it->key, nullptr).iterator;

TerminatedArrayBuilder<RuleData> builder(compactRules->value.release());

builder.grow(pendingRules->size());