Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: Source/core/css/RuleSet.cpp

Issue 152883002: (Concept patch) Simplify WTF::HashTable::add() return value for size and performance (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All r ights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 372 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 { 383 {
384 for (size_t selectorIndex = 0; selectorIndex != kNotFound; selectorIndex = r ule->selectorList().indexOfNextSelectorAfter(selectorIndex)) 384 for (size_t selectorIndex = 0; selectorIndex != kNotFound; selectorIndex = r ule->selectorList().indexOfNextSelectorAfter(selectorIndex))
385 addRule(rule, selectorIndex, addRuleFlags); 385 addRule(rule, selectorIndex, addRuleFlags);
386 } 386 }
387 387
388 void RuleSet::compactPendingRules(PendingRuleMap& pendingMap, CompactRuleMap& co mpactMap) 388 void RuleSet::compactPendingRules(PendingRuleMap& pendingMap, CompactRuleMap& co mpactMap)
389 { 389 {
390 PendingRuleMap::iterator end = pendingMap.end(); 390 PendingRuleMap::iterator end = pendingMap.end();
391 for (PendingRuleMap::iterator it = pendingMap.begin(); it != end; ++it) { 391 for (PendingRuleMap::iterator it = pendingMap.begin(); it != end; ++it) {
392 OwnPtr<LinkedStack<RuleData> > pendingRules = it->value.release(); 392 OwnPtr<LinkedStack<RuleData> > pendingRules = it->value.release();
393 CompactRuleMap::iterator compactRules = compactMap.add(it->key, nullptr) .iterator; 393 CompactRuleMap::ValueType* compactRules = compactMap.add(it->key, nullpt r).iterator;
394 394
395 TerminatedArrayBuilder<RuleData> builder(compactRules->value.release()); 395 TerminatedArrayBuilder<RuleData> builder(compactRules->value.release());
396 builder.grow(pendingRules->size()); 396 builder.grow(pendingRules->size());
397 while (!pendingRules->isEmpty()) { 397 while (!pendingRules->isEmpty()) {
398 builder.append(pendingRules->peek()); 398 builder.append(pendingRules->peek());
399 pendingRules->pop(); 399 pendingRules->pop();
400 } 400 }
401 401
402 compactRules->value = builder.release(); 402 compactRules->value = builder.release();
403 } 403 }
(...skipping 13 matching lines...) Expand all
417 m_universalRules.shrinkToFit(); 417 m_universalRules.shrinkToFit();
418 m_pageRules.shrinkToFit(); 418 m_pageRules.shrinkToFit();
419 m_viewportRules.shrinkToFit(); 419 m_viewportRules.shrinkToFit();
420 m_fontFaceRules.shrinkToFit(); 420 m_fontFaceRules.shrinkToFit();
421 m_keyframesRules.shrinkToFit(); 421 m_keyframesRules.shrinkToFit();
422 m_treeBoundaryCrossingRules.shrinkToFit(); 422 m_treeBoundaryCrossingRules.shrinkToFit();
423 m_shadowDistributedRules.shrinkToFit(); 423 m_shadowDistributedRules.shrinkToFit();
424 } 424 }
425 425
426 } // namespace WebCore 426 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698