Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(592)

Issue 1528633002: move LocalReferenceContributor to new API (Closed)

Created:
5 years ago by danrubel
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove commented out code #

Patch Set 3 : make local functions private' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+792 lines, -1675 lines) Patch
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart View 2 chunks +17 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/label_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart View 1 2 12 chunks +205 lines, -71 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 2 chunks +1 line, -2 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart View 1 chunk +0 lines, -315 lines 0 comments Download
D pkg/analysis_server/lib/src/services/completion/local_suggestion_builder.dart View 1 chunk +0 lines, -139 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/combinator_contributor_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart View 5 chunks +25 lines, -10 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/label_contributor_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart View 117 chunks +535 lines, -312 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
D pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart View 1 chunk +0 lines, -813 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
5 years ago (2015-12-14 18:30:15 UTC) #2
scheglov
LGTM
5 years ago (2015-12-14 18:47:25 UTC) #3
danrubel
5 years ago (2015-12-14 18:57:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
d8494d2f50eb1aa0b58e39e61212125f1965d6d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698