Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

Issue 1528633002: move LocalReferenceContributor to new API (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: make local functions private' Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
index 59e5e699c363ae522c3a4a653a3245b7a8d4c8a5..f549d83c6a9a87e440fe2a80f24b8507d3818ec9 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
@@ -112,7 +112,7 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
if (isDeprecated) {
expect(cs.relevance, equals(DART_RELEVANCE_LOW));
} else {
- expect(cs.relevance, equals(relevance));
+ expect(cs.relevance, equals(relevance), reason: completion);
}
expect(cs.importUri, importUri);
expect(cs.selectionOffset, equals(completion.length));
@@ -160,6 +160,21 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
return cs;
}
+ CompletionSuggestion assertSuggestClassTypeAlias(String name,
+ {int relevance: DART_RELEVANCE_DEFAULT,
+ CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION}) {
+ CompletionSuggestion cs =
+ assertSuggest(name, csKind: kind, relevance: relevance);
+ protocol.Element element = cs.element;
+ expect(element, isNotNull);
+ expect(element.kind, equals(protocol.ElementKind.CLASS_TYPE_ALIAS));
+ expect(element.name, equals(name));
+ expect(element.parameters, isNull);
+ expect(element.returnType, isNull);
+ assertHasNoParameterInfo(cs);
+ return cs;
+ }
+
CompletionSuggestion assertSuggestConstructor(String name,
{int relevance: DART_RELEVANCE_DEFAULT,
String importUri,
@@ -218,20 +233,20 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
CompletionSuggestion assertSuggestFunction(String name, String returnType,
{CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
- bool deprecated: false,
+ bool isDeprecated: false,
int relevance: DART_RELEVANCE_DEFAULT,
String importUri}) {
CompletionSuggestion cs = assertSuggest(name,
csKind: kind,
relevance: relevance,
importUri: importUri,
- isDeprecated: deprecated);
+ isDeprecated: isDeprecated);
expect(cs.returnType, returnType != null ? returnType : 'dynamic');
protocol.Element element = cs.element;
expect(element, isNotNull);
expect(element.kind, equals(protocol.ElementKind.FUNCTION));
expect(element.name, equals(name));
- expect(element.isDeprecated, equals(deprecated));
+ expect(element.isDeprecated, equals(isDeprecated));
String param = element.parameters;
expect(param, isNotNull);
expect(param[0], equals('('));
@@ -243,10 +258,10 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
}
CompletionSuggestion assertSuggestFunctionTypeAlias(
- String name, String returnType, bool isDeprecated,
- [int relevance = DART_RELEVANCE_DEFAULT,
- CompletionSuggestionKind kind = CompletionSuggestionKind.INVOCATION,
- String importUri]) {
+ String name, String returnType, {bool isDeprecated: false,
+ int relevance: DART_RELEVANCE_DEFAULT,
+ CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
+ String importUri}) {
CompletionSuggestion cs = assertSuggest(name,
csKind: kind,
relevance: relevance,
@@ -320,9 +335,9 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
}
CompletionSuggestion assertSuggestSetter(String name,
- [int relevance = DART_RELEVANCE_DEFAULT,
+ {int relevance: DART_RELEVANCE_DEFAULT,
String importUri,
- CompletionSuggestionKind kind = CompletionSuggestionKind.INVOCATION]) {
+ CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION}) {
CompletionSuggestion cs = assertSuggest(name,
csKind: kind,
relevance: relevance,

Powered by Google App Engine
This is Rietveld 408576698