pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart - Issue 1528633002: move LocalReferenceContributor to new API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

Issue 1528633002: move LocalReferenceContributor to new API (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: make local functions private' Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/dart/local_reference_contributor.dart ('k') | pkg/analysis_server/lib/src/services/completion/local_reference_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

index 4f793ec2e8387f8a44fae2152d206fa4494854aa..5c51c2b2dd3593f8b239f7a929f871e71a1c3e3d 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

@@ -16,7 +16,6 @@ import 'package:analysis_server/src/services/completion/dart/common_usage_sorter

import 'package:analysis_server/src/services/completion/dart/contribution_sorter.dart';

import 'package:analysis_server/src/services/completion/dart_completion_cache.dart';

import 'package:analysis_server/src/services/completion/imported_reference_contributor.dart';

-import 'package:analysis_server/src/services/completion/local_reference_contributor.dart';

import 'package:analysis_server/src/services/completion/optype.dart';

import 'package:analysis_server/src/services/search/search_engine.dart';

import 'package:analyzer/file_system/file_system.dart';

@@ -93,7 +92,7 @@ class DartCompletionManager extends CompletionManager {

// LocalReferenceContributor before ImportedReferenceContributor

// because local suggestions take precedence

// and can hide other suggestions with the same name

- new LocalReferenceContributor(),

+ //new LocalReferenceContributor(),

new ImportedReferenceContributor(),

//new KeywordContributor(),

//new ArgListContributor(),