Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1528613004: First cut of mini dart:html. (Closed)

Created:
5 years ago by vsm
Modified:
5 years ago
CC:
dev-compiler+reviews_dartlang.org, Alan Knight, terry
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

First cut of mini dart:html. This gets us going on Angular. Note, this is auto-generated from my hacked up versions of the dom scripts. Still tackling the long tail of sdk errors. R=jmesserly@google.com, leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/dca685525ef402c776fa5be9d1b8ae760b8e8d64

Patch Set 1 #

Patch Set 2 : Delete non html file #

Total comments: 6

Patch Set 3 : Fix build_sdk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34633 lines, -37 lines) Patch
A lib/runtime/dart/_metadata.js View 1 2 1 chunk +59 lines, -0 lines 0 comments Download
A lib/runtime/dart/html.js View 1 2 1 chunk +12706 lines, -0 lines 0 comments Download
A lib/runtime/dart/html_common.js View 1 2 1 chunk +969 lines, -0 lines 0 comments Download
M lib/runtime/dart/js.js View 1 2 3 chunks +9 lines, -4 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M lib/src/compiler.dart View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M test/codegen/expect/html_input.html View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M tool/build_sdk.sh View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tool/input_sdk/lib/_internal/libraries.dart View 1 2 3 chunks +14 lines, -22 lines 0 comments Download
A tool/input_sdk/lib/html/ddc/html_ddc.dart View 1 2 1 chunk +19578 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/html/html_common/conversions.dart View 1 2 1 chunk +369 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/html/html_common/conversions_dart2js.dart View 1 2 1 chunk +99 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/html/html_common/css_class_set.dart View 1 2 1 chunk +244 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/html/html_common/device.dart View 1 2 1 chunk +112 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/html/html_common/filtered_element_list.dart View 1 2 1 chunk +154 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/html/html_common/html_common.dart View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/html/html_common/html_common_ddc.dart View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/html/html_common/lists.dart View 1 2 1 chunk +75 lines, -0 lines 0 comments Download
A tool/input_sdk/lib/html/html_common/metadata.dart View 1 2 1 chunk +74 lines, -0 lines 0 comments Download
M tool/input_sdk/lib/js/dart2js/js_dart2js.dart View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M tool/sdk_expected_errors.txt View 1 2 2 chunks +91 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
vsm
5 years ago (2015-12-15 00:04:20 UTC) #3
Leaf
lgtm
5 years ago (2015-12-15 18:37:36 UTC) #6
Jennifer Messerly
a few suggestions but LGTM otherwise https://codereview.chromium.org/1528613004/diff/10001/tool/build_sdk.sh File tool/build_sdk.sh (right): https://codereview.chromium.org/1528613004/diff/10001/tool/build_sdk.sh#newcode18 tool/build_sdk.sh:18: dart:js dart:mirrors dart:html ...
5 years ago (2015-12-15 19:17:12 UTC) #7
vsm
https://codereview.chromium.org/1528613004/diff/10001/tool/build_sdk.sh File tool/build_sdk.sh (right): https://codereview.chromium.org/1528613004/diff/10001/tool/build_sdk.sh#newcode18 tool/build_sdk.sh:18: dart:js dart:mirrors dart:html \ On 2015/12/15 19:17:12, John Messerly ...
5 years ago (2015-12-15 21:05:27 UTC) #8
vsm
5 years ago (2015-12-15 21:08:32 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:20001) manually as
dca685525ef402c776fa5be9d1b8ae760b8e8d64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698