lib/src/codegen/js_codegen.dart - Issue 1528613004: First cut of mini dart:html.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1528613004: First cut of mini dart:html. (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Fix build_sdk Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_codegen.dart

diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart

index 0ff3baadbffb8904081d3144b30bb3d788b64e54..1ca3993e1a8c9303368e813f868f5389a17da4ea 100644

--- a/lib/src/codegen/js_codegen.dart

+++ b/lib/src/codegen/js_codegen.dart

@@ -1089,6 +1089,9 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ClosureAnnotator {

}

+ if (superCtor == null) {

+ print('Error generating: ${element.displayName}');

+ }

if (superCtor.name == '' && !_shouldCallUnnamedSuperCtor(element)) {

return null;

}

« no previous file with comments | « lib/runtime/dart/js.js ('k') | lib/src/compiler.dart » ('j') | no next file with comments »