Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1528473002: Revert of Add config options to run different GPU APIs to dm and nanobench (Closed)

Created:
5 years ago by reed1
Modified:
5 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@commandbuffer-as-api-03-context-factory-glcontext-type
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add config options to run different GPU APIs to dm and nanobench (patchset #12 id:220001 of https://codereview.chromium.org/1490113005/ ) Reason for revert: speculative revert to see if it unblocks the DEPS roll https://codereview.chromium.org/1529443002 Original issue's description: > Add config options to run different GPU APIs to dm and nanobench > > Add extended config specification form that can be used to run different > gpu backend with different APIs. > > The configs can be specified with the form: > gpu(api=string,dit=bool,nvpr=bool,samples=int) > > This replaces and removes the --gpuAPI flag. > > All existing configs should still work. > > Adds following documentation: > > out/Debug/dm --help config > > Flags: > --config: type: string default: 565 8888 gpu nonrendering > Options: 565 8888 debug gpu gpudebug gpudft gpunull msaa16 msaa4 > nonrendering null nullgpu nvprmsaa16 nvprmsaa4 pdf pdf_poppler skp svg > xps or use extended form 'backend(option=value,...)'. > > Extended form: 'backend(option=value,...)' > > Possible backends and options: > > gpu(api=string,dit=bool,nvpr=bool,samples=int) GPU backend > api type: string default: native. > Select graphics API to use with gpu backend. > Options: > native Use platform default OpenGL or OpenGL ES backend. > gl Use OpenGL. > gles Use OpenGL ES. > debug Use debug OpenGL. > null Use null OpenGL. > dit type: bool default: false. > Use device independent text. > nvpr type: bool default: false. > Use NV_path_rendering OpenGL and OpenGL ES extension. > samples type: int default: 0. > Use multisampling with N samples. > > Predefined configs: > > gpu = gpu() > msaa4 = gpu(samples=4) > msaa16 = gpu(samples=16) > nvprmsaa4 = gpu(nvpr=true,samples=4) > nvprmsaa16 = gpu(nvpr=true,samples=16) > gpudft = gpu(dit=true) > gpudebug = gpu(api=debug) > gpunull = gpu(api=null) > debug = gpu(api=debug) > nullgpu = gpu(api=null) > > BUG=skia:2992 > > Committed: https://skia.googlesource.com/skia/+/e13ca329fca4c28cf4e078561f591ab27b743d23 TBR=bsalomon@google.com,scroggo@google.com,joshualitt@google.com,kkinnunen@nvidia.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:2992 Committed: https://skia.googlesource.com/skia/+/4ff653cab2e1e3cfb02c91df9c9013fc927aa1ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+215 lines, -1041 lines) Patch
M bench/nanobench.cpp View 5 chunks +6 lines, -8 lines 0 comments Download
M dm/DM.cpp View 15 chunks +84 lines, -89 lines 0 comments Download
M dm/DMGpuSupport.h View 2 chunks +4 lines, -2 lines 0 comments Download
M dm/DMSrcSink.h View 2 chunks +2 lines, -1 line 0 comments Download
M dm/DMSrcSink.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M gyp/flags.gyp View 2 chunks +0 lines, -8 lines 0 comments Download
M include/core/SkString.h View 1 chunk +1 line, -16 lines 0 comments Download
M include/gpu/gl/SkNullGLContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/gl/angle/SkANGLEGLContext.h View 1 chunk +6 lines, -13 lines 0 comments Download
M include/gpu/gl/command_buffer/SkCommandBufferGLContext.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/core/SkString.cpp View 1 chunk +7 lines, -26 lines 0 comments Download
M src/gpu/GrContextFactory.h View 4 chunks +13 lines, -22 lines 0 comments Download
M src/gpu/GrContextFactory.cpp View 2 chunks +17 lines, -22 lines 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/gl/angle/SkANGLEGLContext.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M src/gpu/gl/debug/SkDebugGLContext.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/gpu/gl/mesa/SkMesaGLContext.h View 1 chunk +4 lines, -1 line 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +5 lines, -9 lines 0 comments Download
M tests/GrContextFactoryTest.cpp View 1 chunk +4 lines, -8 lines 0 comments Download
M tests/StringTest.cpp View 1 chunk +1 line, -54 lines 0 comments Download
D tests/TestConfigParsing.cpp View 1 chunk +0 lines, -287 lines 0 comments Download
M tools/flags/SkCommandLineFlags.h View 10 chunks +8 lines, -26 lines 0 comments Download
M tools/flags/SkCommandLineFlags.cpp View 5 chunks +23 lines, -36 lines 0 comments Download
M tools/flags/SkCommonFlags.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/flags/SkCommonFlags.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
D tools/flags/SkCommonFlagsConfig.h View 1 chunk +0 lines, -70 lines 0 comments Download
D tools/flags/SkCommonFlagsConfig.cpp View 1 chunk +0 lines, -332 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of Add config options to run different GPU APIs to dm and nanobench
5 years ago (2015-12-14 13:58:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528473002/1
5 years ago (2015-12-14 13:58:13 UTC) #2
commit-bot: I haz the power
5 years ago (2015-12-14 13:58:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4ff653cab2e1e3cfb02c91df9c9013fc927aa1ee

Powered by Google App Engine
This is Rietveld 408576698