Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1528373002: Replace Pass() with std::move in ui/ozone (Closed)

Created:
5 years ago by mkollaro
Modified:
5 years ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace Pass() with std::move in ui/ozone Remove it completely when copy ellision can take care of it. BUG=557422 Committed: https://crrev.com/c0f8a96177f7d7c96a4001e4993c1180624f2eef Cr-Commit-Position: refs/heads/master@{#366354}

Patch Set 1 #

Total comments: 6

Patch Set 2 : #

Patch Set 3 : add #include <utility> #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -47 lines) Patch
M ui/ozone/demo/ozone_demo.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/ozone/platform/caca/caca_window_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/caca/ozone_platform_caca.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/cast/ozone_platform_cast.cc View 1 2 4 chunks +5 lines, -3 lines 0 comments Download
M ui/ozone/platform/cast/surface_factory_cast.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/client_native_pixmap_factory_gbm.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/common/drm_util.cc View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device_generator.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device_manager.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_thread.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/drm_window_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_device.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_surfaceless.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_plane_manager_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/mock_drm_device.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager_unittest.cc View 1 2 7 chunks +8 lines, -6 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_device_handle.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/host/drm_display_host_manager.cc View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/ozone_platform_gbm.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
mkollaro
5 years ago (2015-12-16 14:53:51 UTC) #2
spang
lgtm https://codereview.chromium.org/1528373002/diff/1/ui/ozone/platform/caca/caca_window_manager.cc File ui/ozone/platform/caca/caca_window_manager.cc (right): https://codereview.chromium.org/1528373002/diff/1/ui/ozone/platform/caca/caca_window_manager.cc#newcode140 ui/ozone/platform/caca/caca_window_manager.cc:140: return std::move(canvas); Unnecessary move. Just return canvas; https://codereview.chromium.org/1528373002/diff/1/ui/ozone/platform/caca/ozone_platform_caca.cc ...
5 years ago (2015-12-16 17:25:32 UTC) #3
mkollaro
On 2015/12/16 17:25:32, spang (OOO until Jan) wrote: > lgtm > > https://codereview.chromium.org/1528373002/diff/1/ui/ozone/platform/caca/caca_window_manager.cc > File ...
5 years ago (2015-12-17 12:01:46 UTC) #4
mkollaro
(please ignore previous message) https://codereview.chromium.org/1528373002/diff/1/ui/ozone/platform/caca/caca_window_manager.cc File ui/ozone/platform/caca/caca_window_manager.cc (right): https://codereview.chromium.org/1528373002/diff/1/ui/ozone/platform/caca/caca_window_manager.cc#newcode140 ui/ozone/platform/caca/caca_window_manager.cc:140: return std::move(canvas); On 2015/12/16 17:25:32, ...
5 years ago (2015-12-17 12:02:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528373002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528373002/40001
5 years ago (2015-12-21 08:53:16 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-21 09:09:08 UTC) #9
commit-bot: I haz the power
5 years ago (2015-12-21 09:10:49 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c0f8a96177f7d7c96a4001e4993c1180624f2eef
Cr-Commit-Position: refs/heads/master@{#366354}

Powered by Google App Engine
This is Rietveld 408576698