ui/ozone/platform/caca/caca_window_manager.cc - Issue 1528373002: Replace Pass() with std::move in ui/ozone

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/ozone/platform/caca/caca_window_manager.cc

Issue 1528373002: Replace Pass() with std::move in ui/ozone (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « ui/ozone/demo/ozone_demo.cc ('k') | ui/ozone/platform/caca/ozone_platform_caca.cc » ('j') | ui/ozone/platform/caca/ozone_platform_caca.cc » ('J')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/ozone/platform/caca/caca_window_manager.h"	5 #include "ui/ozone/platform/caca/caca_window_manager.h"

6	6

7 #include "base/trace_event/trace_event.h"	7 #include "base/trace_event/trace_event.h"

8 #include "third_party/skia/include/core/SkCanvas.h"	8 #include "third_party/skia/include/core/SkCanvas.h"

9 #include "third_party/skia/include/core/SkSurface.h"	9 #include "third_party/skia/include/core/SkSurface.h"

10 #include "ui/gfx/skia_util.h"	10 #include "ui/gfx/skia_util.h"

(...skipping 119 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
130	130

131 scoped_ptr<ui::SurfaceOzoneCanvas> CacaWindowManager::CreateCanvasForWidget(	131 scoped_ptr<ui::SurfaceOzoneCanvas> CacaWindowManager::CreateCanvasForWidget(

132 gfx::AcceleratedWidget widget) {	132 gfx::AcceleratedWidget widget) {

133 DCHECK(thread_checker_.CalledOnValidThread());	133 DCHECK(thread_checker_.CalledOnValidThread());

134 CacaWindow* window = windows_.Lookup(widget);	134 CacaWindow* window = windows_.Lookup(widget);

135 DCHECK(window);	135 DCHECK(window);

136	136

137 scoped_ptr<CacaSurface> canvas(new CacaSurface(window));	137 scoped_ptr<CacaSurface> canvas(new CacaSurface(window));

138 bool initialized = canvas->Initialize();	138 bool initialized = canvas->Initialize();

139 DCHECK(initialized);	139 DCHECK(initialized);

140 return canvas.Pass();	140 return std::move(canvas);
	spang 2015/12/16 17:25:32 Unnecessary move. Just return canvas; Unnecessary move. Just return canvas; mkollaro 2015/12/17 12:02:37 Done. Show quoted text On 2015/12/16 17:25:32, spang (OOO until Jan) wrote: > Unnecessary move. Just > > return canvas; Done.
141 }	141 }

142	142

143 } // namespace ui	143 } // namespace ui

OLD	NEW