Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1528323002: Include <algorithm> if you use functions from <algorithm>. (Closed)

Created:
5 years ago by Daniel Bratell
Modified:
5 years ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj, darin-cc_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, eric.carlson_apple.com, Eric Willigers, feature-media-reviews_chromium.org, f(malita), fs, gavinp+loader_chromium.org, gasubic, gyuyoung2, jam, Nate Chapin, jbroman, jchaffraix+rendering, jfernandez, jochen+watch_chromium.org, Justin Novosad, kinuko+watch, kouhei+svg_chromium.org, kozyatinskiy+blink_chromium.org, leviw+renderwatch, loading-reviews+fetch_chromium.org, lushnikov+blink_chromium.org, mcasas+watch_chromium.org, Mikhail, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, philipj_slow, posciak+watch_chromium.org, Manuel Rego, rjwright, rwlbuis, Stephen Chennney, sergeyv+blink_chromium.org, shans, sof, nessy, slimming-paint-reviews_chromium.org, svillar, szager+layoutwatch_chromium.org, tdresser+watch_chromium.org, tyoshino+watch_chromium.org, vcarbune.chromium, vmpstr+blinkwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include <algorithm> if you use functions from <algorithm>. I'm trying to remove #include <algorithm> from common headers because it takes a long time to compile, but then code that actually need <algorithm> need to include that header themselves. This will bring no functional change. BUG=563433 Committed: https://crrev.com/e77640ddf41053b6687984b19b161530c26d8755 Cr-Commit-Position: refs/heads/master@{#365830}

Patch Set 1 #

Patch Set 2 : Split ui parts into a separate review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M components/test_runner/mock_spell_check.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTimeline.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSFontFace.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSGradientValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageSetValue.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ElementRuleCollector.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/PageRuleCollector.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/StylePropertySet.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/CompositorProxy.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/PresentationAttributeStyle.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LayoutSubtreeRootList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLSrcsetParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/track/TextTrackCueList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextQuery.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/GridPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerStackingNode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/GridResolvedPosition.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SMILTimeContainer.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceBase.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/timing/PerformanceObserverEntryList.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/Optional.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/StringImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextPosition.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Daniel Bratell
Jochen, can you please take a look? I'm just adding #include <algorithm> here to maybe ...
5 years ago (2015-12-16 12:33:35 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-17 14:22:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1528323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1528323002/20001
5 years ago (2015-12-17 14:37:32 UTC) #5
haraken
+yutak LGTM
5 years ago (2015-12-17 14:48:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-17 16:05:06 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e77640ddf41053b6687984b19b161530c26d8755 Cr-Commit-Position: refs/heads/master@{#365830}
5 years ago (2015-12-17 16:06:07 UTC) #10
Yuta Kitamura
5 years ago (2015-12-18 04:05:08 UTC) #11
Message was sent while issue was closed.
This is reasonable, LGTM.

Powered by Google App Engine
This is Rietveld 408576698