Disable etw_manifest in the GN Windows build.

Disable etw_manifest in the GN Windows build.

This is currently hooked up incorrectly, resulting in some extra size. Since nobody depends on using this now, we can disable it.

TBR=brucedawson@chromium.org
BUG=569989
Committed: https://crrev.com/b8207ad6c963446716e84d265c03c8d7e90508d9
Cr-Commit-Position: refs/heads/master@{#365645}

[brucedawson, 2015-12-15 19:32:55]

One concern - can you check?

https://codereview.chromium.org/1528093003/diff/1/base/trace_event/etw_manife...
File base/trace_event/etw_manifest/BUILD.gn (right):

https://codereview.chromium.org/1528093003/diff/1/base/trace_event/etw_manife...
base/trace_event/etw_manifest/BUILD.gn:16: message_compiler("chrome_events_win")
{
Does this control the linking of the .rc/.bin files only, or does it also
control the running of the message compiler?

The message compiler generates a header file which is included by
base\trace_event\trace_event_etw_export_win.cc so not running the message
compiler will lead to compile failures.

These failures may be temporarily hidden if chrome_events_win.h is leftover from
a previous build, so watch out for that.

[brettw, 2015-12-16 19:19:10]

Fix up that generates but doesn't compile the sources.

https://codereview.chromium.org/1528093003/diff/1/base/trace_event/etw_manife...
File base/trace_event/etw_manifest/BUILD.gn (right):

https://codereview.chromium.org/1528093003/diff/1/base/trace_event/etw_manife...
base/trace_event/etw_manifest/BUILD.gn:16: message_compiler("chrome_events_win")
{
Good catch! This would have been super annoying to find later.

[brettw, 2015-12-16 19:19:13]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 19:20:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528093003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528093003/20001

[commit-bot: I haz the power, 2015-12-16 20:31:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 20:31:09]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-12-16 22:25:21]

Description was changed from

==========
Disable etw_manifest in the GN Windows build.

This is currently hooked up incorrectly, resulting in some extra size. Since
nobody depends on using this now, we can disable it.

R=brucedawson@chromium.org
BUG=569989
==========

to

==========
Disable etw_manifest in the GN Windows build.

This is currently hooked up incorrectly, resulting in some extra size. Since
nobody depends on using this now, we can disable it.

TBR=brucedawson@chromium.org
BUG=569989
==========

[brettw, 2015-12-16 22:25:24]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-12-16 22:26:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1528093003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1528093003/20001

[commit-bot: I haz the power, 2015-12-16 22:38:33]

Description was changed from

==========
Disable etw_manifest in the GN Windows build.

This is currently hooked up incorrectly, resulting in some extra size. Since
nobody depends on using this now, we can disable it.

TBR=brucedawson@chromium.org
BUG=569989
==========

to

==========
Disable etw_manifest in the GN Windows build.

This is currently hooked up incorrectly, resulting in some extra size. Since
nobody depends on using this now, we can disable it.

TBR=brucedawson@chromium.org
BUG=569989
==========

[commit-bot: I haz the power, 2015-12-16 22:38:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-16 22:39:16]

Description was changed from

==========
Disable etw_manifest in the GN Windows build.

This is currently hooked up incorrectly, resulting in some extra size. Since
nobody depends on using this now, we can disable it.

TBR=brucedawson@chromium.org
BUG=569989
==========

to

==========
Disable etw_manifest in the GN Windows build.

This is currently hooked up incorrectly, resulting in some extra size. Since
nobody depends on using this now, we can disable it.

TBR=brucedawson@chromium.org
BUG=569989

Committed: https://crrev.com/b8207ad6c963446716e84d265c03c8d7e90508d9
Cr-Commit-Position: refs/heads/master@{#365645}
==========

[commit-bot: I haz the power, 2015-12-16 22:39:17]

Patchset 2 (id:??) landed as
https://crrev.com/b8207ad6c963446716e84d265c03c8d7e90508d9
Cr-Commit-Position: refs/heads/master@{#365645}