Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: base/trace_event/etw_manifest/BUILD.gn

Issue 1528093003: Disable etw_manifest in the GN Windows build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: generate but don't compile Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/win/message_compiler.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/etw_manifest/BUILD.gn
diff --git a/base/trace_event/etw_manifest/BUILD.gn b/base/trace_event/etw_manifest/BUILD.gn
index ed83aab0ed4fdb956de24d592e0113c02798bb0d..53f55209c6d795ac9fd9d525262aa3191f48bffa 100644
--- a/base/trace_event/etw_manifest/BUILD.gn
+++ b/base/trace_event/etw_manifest/BUILD.gn
@@ -17,4 +17,9 @@ message_compiler("chrome_events_win") {
]
user_mode_logging = true
+
+ # TOOD(brucedawson) bug 569989: Enable ETW manifest and compile and link it
+ # into the proper places. Enabling as-is may add the resources to too many
+ # targets. See the bug for more information.
+ compile_generated_code = false
}
« no previous file with comments | « no previous file | build/win/message_compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698