Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: base/trace_event/etw_manifest/BUILD.gn

Issue 1528093003: Disable etw_manifest in the GN Windows build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/win/message_compiler.gni") 5 import("//build/win/message_compiler.gni")
6 6
7 assert(is_win, "This only runs on Windows.") 7 assert(is_win, "This only runs on Windows.")
8 8
9 message_compiler("chrome_events_win") { 9 # TOOD(brucedawson) bug 569989: Enable ETW manifest and link it into the
10 visibility = [ 10 # proper places. Enabling as-is may add this to too many targets. See the bug
11 "//base/trace_event/*", 11 # for more information.
12 "//chrome:main_dll", 12 if (true) {
13 ] 13 group("chrome_events_win") {
14 }
15 } else {
16 message_compiler("chrome_events_win") {
brucedawson 2015/12/15 19:32:54 Does this control the linking of the .rc/.bin file
brettw 2015/12/16 19:19:09 Good catch! This would have been super annoying to
17 visibility = [
18 "//base/trace_event/*",
19 "//chrome:main_dll",
20 ]
14 21
15 sources = [ 22 sources = [
16 "chrome_events_win.man", 23 "chrome_events_win.man",
17 ] 24 ]
18 25
19 user_mode_logging = true 26 user_mode_logging = true
27 }
20 } 28 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698